Code

Opened 6 years ago

Closed 6 years ago

#6419 closed (fixed)

Unused prints in loaddata.py

Reported by: Hauser <hauserx@…> Owned by: nobody
Component: Core (Other) Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In file core/management/commands/loaddata.py there are three verbosity level checks that cannot be true.

verbosity parameter has choices=['0', '1', '2'], and these checks looks like that:

128             if verbosity > 2:
129                 print "No fixtures found."


Changes were made in this commit:

http://code.djangoproject.com/changeset/6883

Probably it should be changed to >= 2

Attachments (1)

loaddata.patch (1.1 KB) - added by Grzegorz Lukasik <hauserx@…> 6 years ago.
patch that changes > to >=

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by Grzegorz Lukasik <hauserx@…>

patch that changes > to >=

comment:1 Changed 6 years ago by SmileyChris

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 6 years ago by gwilson

  • Resolution set to fixed
  • Status changed from new to closed

(In [7037]) Fixed #6419 -- Fixed verbosity level checks in loaddata command that were raised to unobtainable levels in [6883].

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.