Opened 18 years ago

Closed 18 years ago

#6419 closed (fixed)

Unused prints in loaddata.py

Reported by: Hauser <hauserx@…> Owned by: nobody
Component: Core (Other) Version: dev
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In file core/management/commands/loaddata.py there are three verbosity level checks that cannot be true.

verbosity parameter has choices=['0', '1', '2'], and these checks looks like that:

128             if verbosity > 2:
129                 print "No fixtures found."


Changes were made in this commit:

​http://code.djangoproject.com/changeset/6883

Probably it should be changed to >= 2

Attachments (1)

loaddata.patch​ (1.1 KB ) - added by Grzegorz Lukasik <hauserx@…> 18 years ago.
patch that changes > to >=

Download all attachments as: .zip

Change History (3)

by Grzegorz Lukasik <hauserx@…>, 18 years ago

Attachment: loaddata.patch​ added

patch that changes > to >=

comment:1 by Chris Beaven, 18 years ago

Has patch: set
Triage Stage: Unreviewed → Ready for checkin

comment:2 by Gary Wilson, 18 years ago

Resolution: → fixed
Status: new → closed

(In [7037]) Fixed #6419 -- Fixed verbosity level checks in loaddata command that were raised to unobtainable levels in [6883].

Note: See TracTickets for help on using tickets.
Back to Top