Opened 20 years ago

Closed 20 years ago

Last modified 20 years ago

#641 closed defect (fixed)

[patch] Fix re-raise in d.c.h.base

Reported by: Sune Kirkeby <sune.kirkeby@…> Owned by: Adrian Holovaty
Component: Core (Other) Version:
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description 

=== django/core/handlers/base.py
==================================================================
--- django/core/handlers/base.py        (revision 2884)
+++ django/core/handlers/base.py        (local)
@@ -74,7 +74,7 @@
                     response = middleware_method(request, e)
                     if response:
                         return response
-                raise e
+                raise
 
             # Complain if the view returned None (a common error).
             if response is None:

This fixes the base-handler to properly re-raise exceptions, so you can see where they come from, and not get a completely useless traceback.

Change History (2)

comment:1 by Adrian Holovaty, 20 years ago

Resolution: → fixed
Status: new → closed

(In [949]) Fixed #641 -- Fixed re-raise in django.core.handlers.base. Thanks, Sune

comment:2 by Adrian Holovaty, 20 years ago

(In [1076]) Fixed bug in django.utils.decorators.decorator_from_middleware -- it wasn't raising exceptions. Refs #641

Note: See TracTickets for help on using tickets.
Back to Top