Opened 17 years ago
Closed 17 years ago
#6401 closed (fixed)
widgets.SelectMultiple needs custom is_empty
Reported by: | Owned by: | nobody | |
---|---|---|---|
Component: | Forms | Version: | newforms-admin |
Severity: | Keywords: | selectmultiple, is_empty, manytomany | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Noticed problems in newforms-admin with inline edits containing ManyToMany-fields never being considered as empty.
Adding [] (empty list) to the values considered empty by the widget solves this.
Attachments (1)
Change History (8)
by , 17 years ago
Attachment: | widgets.diff added |
---|
comment:1 by , 17 years ago
Triage Stage: | Unreviewed → Ready for checkin |
---|
comment:2 by , 17 years ago
follow-up: 4 comment:3 by , 17 years ago
Version: | SVN → newforms-admin |
---|
comment:4 by , 17 years ago
Replying to brosner:
Regarding version change: Although I came across the problem when using newforms-admin I consider this is a general newforms patch. My description wasn't rather clear on that though.
comment:5 by , 17 years ago
It is a general newforms problem, but is_empty
only exists in newforms-admin.
comment:6 by , 17 years ago
Triage Stage: | Ready for checkin → Accepted |
---|
The patch will need some updating for nfa HEAD. Can someone look into whether it is still a problem?
comment:7 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Closing this ticket has it is likely to have been fixed during the PyCon sprints. Please reopen if this can be reproduced on HEAD of newforms-admin.
See also #4051.