Code

Opened 6 years ago

Closed 6 years ago

#6401 closed (fixed)

widgets.SelectMultiple needs custom is_empty

Reported by: STemplar <simon@…> Owned by: nobody
Component: Forms Version: newforms-admin
Severity: Keywords: selectmultiple, is_empty,manytomany
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Noticed problems in newforms-admin with inline edits containing ManyToMany-fields never being considered as empty.
Adding [] (empty list) to the values considered empty by the widget solves this.

Attachments (1)

widgets.diff (587 bytes) - added by STemplar 6 years ago.

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by STemplar

comment:1 Changed 6 years ago by Simon Greenhill <dev@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 6 years ago by mattmcc

See also #4051.

comment:3 follow-up: Changed 6 years ago by brosner

  • Version changed from SVN to newforms-admin

comment:4 in reply to: ↑ 3 Changed 6 years ago by STemplar <simon@…>

Replying to brosner:
Regarding version change: Although I came across the problem when using newforms-admin I consider this is a general newforms patch. My description wasn't rather clear on that though.

comment:5 Changed 6 years ago by brosner

It is a general newforms problem, but is_empty only exists in newforms-admin.

comment:6 Changed 6 years ago by brosner

  • Triage Stage changed from Ready for checkin to Accepted

The patch will need some updating for nfa HEAD. Can someone look into whether it is still a problem?

comment:7 Changed 6 years ago by brosner

  • Resolution set to fixed
  • Status changed from new to closed

Closing this ticket has it is likely to have been fixed during the PyCon sprints. Please reopen if this can be reproduced on HEAD of newforms-admin.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.