Code

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#6394 closed (fixed)

custom_sql_for_model(): Small patch to remove comments better

Reported by: Thomas Güttler <hv@…> Owned by: nobody
Component: Core (Other) Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Hi,

this is a small patch to remove comments from custom sql files better.

My custom sql file started like this:

-- CREATE LANGUAGE "plpythonu";

-- Comment

Before my patch the first sql command was '-- CREATE LANGUAGE "plpythonu";'
this caused an empty ProgrammingError with psycopg2.

Attachments (1)

sql_comments.diff (637 bytes) - added by Thomas Güttler <hv@…> 6 years ago.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by Thomas Güttler <hv@…>

comment:1 Changed 6 years ago by jacob

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 6 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [7591]) Fixed #6394: improved comment stripping in initial SQL files. Thanks, Thomas Guttler.

comment:3 Changed 6 years ago by guettli

  • Cc hv@… removed

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.