#6394 closed (fixed)
custom_sql_for_model(): Small patch to remove comments better
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | Core (Other) | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Hi,
this is a small patch to remove comments from custom sql files better.
My custom sql file started like this:
-- CREATE LANGUAGE "plpythonu"; -- Comment
Before my patch the first sql command was '-- CREATE LANGUAGE "plpythonu";'
this caused an empty ProgrammingError with psycopg2.
Attachments (1)
Change History (4)
by , 16 years ago
| Attachment: | sql_comments.diff added |
|---|
comment:1 by , 16 years ago
| Triage Stage: | Unreviewed → Ready for checkin |
|---|
comment:2 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 by , 16 years ago
| Cc: | removed |
|---|
Note:
See TracTickets
for help on using tickets.
(In [7591]) Fixed #6394: improved comment stripping in initial SQL files. Thanks, Thomas Guttler.