Opened 8 years ago

Closed 7 years ago

#6356 closed (fixed)

EasyInstance url() not marked safe

Reported by: tangerine Owned by: nobody
Component: contrib.databrowse Version: master
Severity: Keywords: databrowse
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

While using the databrowse app I noticed that the url method of EasyInstance is not marking the returned string as safe. I've attached a patch which marks this safe as well as a change to the __repr__ method of EasyModel to match the use of smart_str() as on other other classes.

Attachments (1)

datastructures.diff (993 bytes) - added by tangerine 8 years ago.
Patch

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by tangerine

Patch

comment:1 Changed 8 years ago by Simon Greenhill <dev@…>

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [7061]) Fixed #6356 -- Added a mark_safe() call that was missed in a url() method. Thanks, tangerine.

Note: See TracTickets for help on using tickets.
Back to Top