Opened 7 years ago

Closed 7 years ago

Last modified 3 years ago

#6340 closed Uncategorized (wontfix)

auth.logout view doesn't use LOGOUT_URL in settings.py

Reported by: Alper KANAT <alperkanat@…> Owned by: dtulig
Component: Generic views Version: master
Severity: Normal Keywords: auth, view, logout
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

title says it all :)

Attachments (1)

logout_url.diff (2.3 KB) - added by dtulig 7 years ago.
Adds LOGOUT_URL support to the logout view.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 7 years ago by dtulig

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to dtulig
  • Patch needs improvement unset
  • Status changed from new to assigned

Changed 7 years ago by dtulig

Adds LOGOUT_URL support to the logout view.

comment:2 Changed 7 years ago by Simon Greenhill <dev@…>

  • Triage Stage changed from Unreviewed to Ready for checkin

comment:3 Changed 7 years ago by mtredinnick

Settings should never be used at import time, which means don't use them as default arguments for functions. Otherwise you cannot import those modules without having already configured settings, which is inconvenient.

comment:4 Changed 7 years ago by mtredinnick

  • Resolution set to wontfix
  • Status changed from assigned to closed

Looking at this more closely, I think it's a wontfix. The logout() method, by default, displays a particular page (it doesn't do a redirect). If you want it to do a redirect, you can pass in the URL to redirect to, so the functionality is already possible. This patch would just change the default to be a redirect, which isn't necessarily a clear win, so would be a backwards incompatible change that would be more annoying than useful. Since either behaviour is possible at the moment, let's leave it alone.

comment:5 Changed 3 years ago by dana@…

  • Easy pickings unset
  • Severity set to Normal
  • Type set to Uncategorized
  • UI/UX unset

Maybe a note about this in the documentation would be appropriate as if there is a LOGOUT_URL setting but it doesn't do anything could be bit confusing for new users...

Note: See TracTickets for help on using tickets.
Back to Top