auth.logout view doesn't use LOGOUT_URL in settings.py

[Alper KANAT <alperkanat@…>]

title says it all :)

[David Tulig]

Adds LOGOUT_URL support to the logout view.

[Malcolm Tredinnick]

Settings should never be used at import time, which means don't use them as default arguments for functions. Otherwise you cannot import those modules without having already configured settings, which is inconvenient.

[Malcolm Tredinnick]

Looking at this more closely, I think it's a wontfix. The logout() method, by default, displays a particular page (it doesn't do a redirect). If you want it to do a redirect, you can pass in the URL to redirect to, so the functionality is already possible. This patch would just change the default to be a redirect, which isn't necessarily a clear win, so would be a backwards incompatible change that would be more annoying than useful. Since either behaviour is possible at the moment, let's leave it alone.

[dana@…]

Maybe a note about this in the documentation would be appropriate as if there is a LOGOUT_URL setting but it doesn't do anything could be bit confusing for new users...