Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#634 closed defect (fixed)

[patch] admin shortcuts don't honor existing http:// absolute urls

Reported by: hugo Owned by: adrian
Component: contrib.admin Version:
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

When you have objects in your model that return serverabsolute urls with leading http://, they aren't honored by the current r/ shortcut view - it still prepends the site. The attached patch honors those URLs and if it starts with http:// (should maybe extended to https://, too?), it just returns the URL without attaching some site stuff.

I use a http:// carrying URL in one of my models where objects in the database return a get_<field>_url() result as their absolute url, because they are just media files listed in the database.

Attachments (1)

shortcut-fix.diff (1.1 KB) - added by hugo 10 years ago.
fixes admin shortcuts to honor leading http://

Download all attachments as: .zip

Change History (3)

Changed 10 years ago by hugo

fixes admin shortcuts to honor leading http://

comment:1 Changed 10 years ago by hugo

  • Summary changed from admin shortcuts don't honor existing http:// absolute urls to [patch] admin shortcuts don't honor existing http:// absolute urls

comment:2 Changed 10 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [903]) Fixed #634 -- Changed shortcut view to accept get_absolute_url()s that return URLs starting with http. Thanks, Hugo

Note: See TracTickets for help on using tickets.
Back to Top