Code

Opened 7 years ago

Closed 6 years ago

#6303 closed (fixed)

Language parameter is not handled the right way in SyndicationFeed, force_unicode should be replaced by to_unicode

Reported by: david Owned by: nobody
Component: contrib.syndication Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

This way, "if self.feed['language'\] is not None:" test succeed, otherwise self.feed['language'] == u'None' and this test always returns False which results in xml:lang="None" attribute in the feed header.

Attachments (1)

patch_django_6303.diff (613 bytes) - added by david 7 years ago.
One-line patch

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by david

One-line patch

comment:1 Changed 7 years ago by Simon Greenhill <dev@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 6 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [7066]) Fixed #6303 -- Handle missing language specification in feed generation. Thanks, david.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.