Opened 16 years ago

Closed 16 years ago

#6303 closed (fixed)

Language parameter is not handled the right way in SyndicationFeed, force_unicode should be replaced by to_unicode

Reported by: David Larlet Owned by: nobody
Component: contrib.syndication Version: dev
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

This way, "if self.feed['language'\] is not None:" test succeed, otherwise self.feed['language'] == u'None' and this test always returns False which results in xml:lang="None" attribute in the feed header.

Attachments (1)

patch_django_6303.diff​ (613 bytes ) - added by David Larlet 16 years ago.
One-line patch

Download all attachments as: .zip

Change History (3)

by David Larlet, 16 years ago

Attachment: patch_django_6303.diff​ added

One-line patch

comment:1 by Simon Greenhill <dev@…>, 16 years ago

Triage Stage: Unreviewed → Ready for checkin

comment:2 by Malcolm Tredinnick, 16 years ago

Resolution: → fixed
Status: new → closed

(In [7066]) Fixed #6303 -- Handle missing language specification in feed generation. Thanks, david.

Note: See TracTickets for help on using tickets.
Back to Top