Code

Opened 6 years ago

Closed 3 years ago

#6282 closed (fixed)

Clarify comment for MEDIA_URL in settings.py

Reported by: apollo13 Owned by: nobody
Component: Core (Other) Version: master
Severity: Keywords: settings MEDIA_URL
Cc: apollo13@… Triage Stage: Design decision needed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Is there a reason why the comment for MEDIA_URL suggests

Make sure to use a trailing slash if there is a path component (optional in other cases).

Wouldn't be wise to suggest using a trailing slash all the time? This way the MEDIA_URL would be consistent and we could use {{MEDIA_URL}}path/to/file in templates without caring about a trailing slash.

Attachments (0)

Change History (2)

comment:1 Changed 6 years ago by Simon Greenhill <dev@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

comment:2 Changed 3 years ago by julien

  • Resolution set to fixed
  • Status changed from new to closed

Well, it seems like this has been fixed at some stage. The comment is now pretty clear: http://code.djangoproject.com/browser/django/trunk/django/conf/project_template/settings.py?rev=15501#L50

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.