Opened 9 years ago

Closed 9 years ago

#6232 closed (duplicate)

ifchanged template tag does not allow paramater with filter

Reported by: keizie@… Owned by: nobody
Component: Template system Version: 0.96
Severity: Keywords: tag filter
Cc: django-ko@… Triage Stage: Ready for checkin
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description (last modified by Gary Wilson)

{% ifchanged var|filter %} blah {% endifchanged %} seems to fail silently.
This could be an enhancement.

Attachments (1)

6232.diff (2.7 KB) - added by Chris Beaven 9 years ago.
enhancement, with test

Download all attachments as: .zip

Change History (6)

comment:1 Changed 9 years ago by Gary Wilson

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Resolution: invalid
Status: newclosed

All template tags and filters are supposed to fail silently.

comment:2 Changed 9 years ago by keizie@…

Resolution: invalid
Status: closedreopened

Silent failure is not the point at all.

ifchanged does not allow var with filter but just var alone.
I want to use var|filter as parameter of ifchanged.

Close this ticket if you don't allow such syntax.

comment:3 Changed 9 years ago by Gary Wilson

Description: modified (diff)
Summary: ifchanged paramater with filterifchanged template tag does not allow paramater with filter
Triage Stage: UnreviewedAccepted

In that case, I'll re-open this.

Changed 9 years ago by Chris Beaven

Attachment: 6232.diff added

enhancement, with test

comment:4 Changed 9 years ago by Chris Beaven

Triage Stage: AcceptedReady for checkin

If Gary accepts the idea, then this patch handles it nicely so no reason not to push to checkin.

comment:5 Changed 9 years ago by Malcolm Tredinnick

Resolution: duplicate
Status: reopenedclosed

Dupe of #5756.

This is fixing the symptom, not the root problem (there are other tags with the same problem, so we should fix them all).

Note: See TracTickets for help on using tickets.
Back to Top