Opened 9 years ago

Closed 9 years ago

#6212 closed (fixed)

models.NullBooleanField.formfield() returns CharField (instead of newforms.NullBooleanField)

Reported by: anonymous Owned by: nobody
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Tried to get an answer on IRC as to whether there was a reason for this omission or whether it's just a bug.

Attachments (2)

NullBooleanField_formfield.diff (717 bytes) - added by anonymous 9 years ago.
patch to add the missing method
6212.diff (656 bytes) - added by Chris Beaven 9 years ago.

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by anonymous

patch to add the missing method

comment:1 Changed 9 years ago by Chris Beaven

Component: Database wrapperdjango.newforms
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Summary: models.NullBooleanField.formfield() returns CharField (vs NullBooleanField)models.NullBooleanField.formfield() returns CharField (instead of newforms.NullBooleanField)
Triage Stage: UnreviewedAccepted

Changed 9 years ago by Chris Beaven

Attachment: 6212.diff added

comment:2 Changed 9 years ago by Chris Beaven

Triage Stage: AcceptedReady for checkin

Pretty straight-forward omission. My patch follows the formatting of the others, anonymous' was a bit hackish

comment:3 Changed 9 years ago by Malcolm Tredinnick

Resolution: fixed
Status: newclosed

(In [6935]) Fixed #6212 -- Give models.NullBooleanField the right default newforms field. Patch from SmileyChris.

Note: See TracTickets for help on using tickets.
Back to Top