Code

Opened 6 years ago

Closed 6 years ago

#6202 closed (fixed)

FilteredSelectMultiple widget does not have showAddAnotherPopup [newforms-admin]

Reported by: erik Owned by: nobody
Component: contrib.admin Version: newforms-admin
Severity: Keywords: nfa-blocker
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: UI/UX:

Description

The FilteredSelectMultiple widget for m2m-relations does not allow to add another related object using a javascript popup window (as it does in old-admin).

Patch: Pass the represented related model on widget initialization. When rendering use this information to add the showAddAnotherPopup code.

Attachments (1)

6202.diff (2.5 KB) - added by erik 6 years ago.
Patch

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by erik

Patch

comment:1 Changed 6 years ago by erik

  • Has patch set
  • Needs documentation unset
  • Needs tests set
  • Patch needs improvement unset

Checked "Has patch".

comment:2 Changed 6 years ago by brosner

  • Keywords nfa-blocker added
  • Triage Stage changed from Unreviewed to Ready for checkin

Looks good to me. Tagging with nfa-blocker since this patch will bring some functionality back up to par with old-admin.

comment:3 Changed 6 years ago by brosner

  • Resolution set to fixed
  • Status changed from new to closed

(In [7195]) newforms-admin: Fixed #6202 -- FilteredSelectMultiple is now wrapped with RelatedFieldWidgetWrapper to display the add button.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.