Code

Opened 6 years ago

Closed 2 years ago

#6163 closed Bug (fixed)

"manage.py help runfcgi" doesn't show default values for some parameters

Reported by: ash Owned by: nobody
Component: Core (Management commands) Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

manage.py help runfcgi

doesn't show default values for maxspare, minspare, maxchildren and workdir parameters.

I've made a patch to fix it.

Attachments (2)

runfcgi_default.diff (2.7 KB) - added by ash 6 years ago.
6163-2.diff (2.9 KB) - added by claudep 2 years ago.
Patch updated to current trunk (method option untouched)

Download all attachments as: .zip

Change History (12)

comment:1 Changed 6 years ago by ash

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to ash
  • Patch needs improvement unset
  • Status changed from new to assigned

comment:2 Changed 6 years ago by ash

  • Summary changed from "manage.py help runfcgi" should show default parameter values to "manage.py help runfcgi" doesn't show default values for some parameters

Changed 6 years ago by ash

comment:3 Changed 6 years ago by ash

  • Owner changed from ash to nobody
  • Status changed from assigned to new

Ok, after a month of silence, I'll describe a problem I'm trying to solve.

When I run

manage.py help runfcgi

I don't see what are the default values for certain parameters (e.g. maxspare, minspare, maxchildren).

Currently you need to read source to find it out:

django/core/servers/fastcgi.py

Note that the patch dynamically fills help message from "FASTCGI_OPTIONS" dictionary.

(I've updated the patch a little bit -- to stop using hardcoded "method" default value.)

comment:4 Changed 6 years ago by SmileyChris

  • Triage Stage changed from Unreviewed to Design decision needed

I note that you've actually changed the default from fork to prefork. I'm no expert in this area so I'm not sure if the code or docs were wrong, so I'll push to a design decision.

comment:5 Changed 6 years ago by ash

Good point, SmileyChris!

But it doesn't matter whether it's fork or prefork, because django/core/servers/fastcgi.py already has the following around line 105:

    if options['method'] in ('prefork', 'fork'):

comment:6 Changed 6 years ago by ash

  • Triage Stage changed from Design decision needed to Unreviewed

5 months of silence...

I've changed stage back to "Unreviewed". I believe there's really nothing to decide (see my last comment). If you disagree, feel free to put "Design decision needed" back.

comment:7 Changed 6 years ago by jacob

  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted

comment:8 Changed 3 years ago by gabrielhurley

  • Severity set to Normal
  • Type set to Bug

Changed 2 years ago by claudep

Patch updated to current trunk (method option untouched)

comment:9 Changed 2 years ago by claudep

  • Easy pickings unset
  • Patch needs improvement unset
  • UI/UX unset

comment:10 Changed 2 years ago by julien

  • Resolution set to fixed
  • Status changed from new to closed

In [17330]:

Fixed #6163 -- Made "manage.py help runfcgi" display proper default values for the runfcgi options. Thanks to ash and Claude Paroz.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.