Opened 17 years ago
Closed 13 years ago
#6163 closed Bug (fixed)
"manage.py help runfcgi" doesn't show default values for some parameters
| Reported by: | Alexey Shamrin | Owned by: | nobody |
|---|---|---|---|
| Component: | Core (Management commands) | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
manage.py help runfcgi
doesn't show default values for maxspare, minspare, maxchildren and workdir parameters.
I've made a patch to fix it.
Attachments (2)
Change History (12)
comment:1 by , 17 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:2 by , 17 years ago
| Summary: | "manage.py help runfcgi" should show default parameter values → "manage.py help runfcgi" doesn't show default values for some parameters |
|---|
by , 17 years ago
| Attachment: | runfcgi_default.diff added |
|---|
comment:3 by , 17 years ago
| Owner: | changed from to |
|---|---|
| Status: | assigned → new |
comment:4 by , 17 years ago
| Triage Stage: | Unreviewed → Design decision needed |
|---|
I note that you've actually changed the default from fork to prefork. I'm no expert in this area so I'm not sure if the code or docs were wrong, so I'll push to a design decision.
comment:5 by , 17 years ago
Good point, SmileyChris!
But it doesn't matter whether it's fork or prefork, because django/core/servers/fastcgi.py already has the following around line 105:
if options['method'] in ('prefork', 'fork'):
comment:6 by , 17 years ago
| Triage Stage: | Design decision needed → Unreviewed |
|---|
5 months of silence...
I've changed stage back to "Unreviewed". I believe there's really nothing to decide (see my last comment). If you disagree, feel free to put "Design decision needed" back.
comment:7 by , 17 years ago
| Patch needs improvement: | set |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:8 by , 14 years ago
| Severity: | → Normal |
|---|---|
| Type: | → Bug |
by , 13 years ago
| Attachment: | 6163-2.diff added |
|---|
Patch updated to current trunk (method option untouched)
comment:9 by , 13 years ago
| Easy pickings: | unset |
|---|---|
| Patch needs improvement: | unset |
| UI/UX: | unset |
Ok, after a month of silence, I'll describe a problem I'm trying to solve.
When I run
I don't see what are the default values for certain parameters (e.g. maxspare, minspare, maxchildren).
Currently you need to read source to find it out:
Note that the patch dynamically fills help message from "FASTCGI_OPTIONS" dictionary.
(I've updated the patch a little bit -- to stop using hardcoded "method" default value.)