Opened 16 years ago

Closed 12 years ago

#6163 closed Bug (fixed)

"manage.py help runfcgi" doesn't show default values for some parameters

Reported by: Alexey Shamrin Owned by: nobody
Component: Core (Management commands) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

manage.py help runfcgi

doesn't show default values for maxspare, minspare, maxchildren and workdir parameters.

I've made a patch to fix it.

Attachments (2)

runfcgi_default.diff (2.7 KB ) - added by Alexey Shamrin 16 years ago.
6163-2.diff (2.9 KB ) - added by Claude Paroz 12 years ago.
Patch updated to current trunk (method option untouched)

Download all attachments as: .zip

Change History (12)

comment:1 by Alexey Shamrin, 16 years ago

Owner: changed from nobody to Alexey Shamrin
Status: newassigned

comment:2 by Alexey Shamrin, 16 years ago

Summary: "manage.py help runfcgi" should show default parameter values"manage.py help runfcgi" doesn't show default values for some parameters

by Alexey Shamrin, 16 years ago

Attachment: runfcgi_default.diff added

comment:3 by Alexey Shamrin, 16 years ago

Owner: changed from Alexey Shamrin to nobody
Status: assignednew

Ok, after a month of silence, I'll describe a problem I'm trying to solve.

When I run

manage.py help runfcgi

I don't see what are the default values for certain parameters (e.g. maxspare, minspare, maxchildren).

Currently you need to read source to find it out:

django/core/servers/fastcgi.py

Note that the patch dynamically fills help message from "FASTCGI_OPTIONS" dictionary.

(I've updated the patch a little bit -- to stop using hardcoded "method" default value.)

comment:4 by Chris Beaven, 16 years ago

Triage Stage: UnreviewedDesign decision needed

I note that you've actually changed the default from fork to prefork. I'm no expert in this area so I'm not sure if the code or docs were wrong, so I'll push to a design decision.

comment:5 by Alexey Shamrin, 16 years ago

Good point, SmileyChris!

But it doesn't matter whether it's fork or prefork, because django/core/servers/fastcgi.py already has the following around line 105:

    if options['method'] in ('prefork', 'fork'):

comment:6 by Alexey Shamrin, 16 years ago

Triage Stage: Design decision neededUnreviewed

5 months of silence...

I've changed stage back to "Unreviewed". I believe there's really nothing to decide (see my last comment). If you disagree, feel free to put "Design decision needed" back.

comment:7 by Jacob, 16 years ago

Patch needs improvement: set
Triage Stage: UnreviewedAccepted

comment:8 by Gabriel Hurley, 13 years ago

Severity: Normal
Type: Bug

by Claude Paroz, 12 years ago

Attachment: 6163-2.diff added

Patch updated to current trunk (method option untouched)

comment:9 by Claude Paroz, 12 years ago

Easy pickings: unset
Patch needs improvement: unset
UI/UX: unset

comment:10 by Julien Phalip, 12 years ago

Resolution: fixed
Status: newclosed

In [17330]:

Fixed #6163 -- Made "manage.py help runfcgi" display proper default values for the runfcgi options. Thanks to ash and Claude Paroz.

Note: See TracTickets for help on using tickets.
Back to Top