provide doctest build helper

[Antti Kaihola]

I suggest a tiny refactoring to the django.test.simple module: extract the doctest.DocTestSuite() call to its own function and use that in build_suite() twice.

This provides two benefits:

• DRY in django.test.simple
• doctest suite creation shortcut for suite() function in models.py or tests.py

Currently to include a doctest for an arbitrary module in the custom test suite, one must do:

from unittest import TestSuite
from django.test import _doctest as doctest
from django.test.simple import doctestOutputChecker
from django.test.testcases import DocTestRunner
import mymodule

def suite()
    suite = TestSuite()
    suite.addTest(doctest.DocTestSuite(
        mymodule,
        checker=doctestOutputChecker,
        runner=DocTestRunner))
    return suite

This refactoring simplifies the above to just:

from unittest import TestSuite
from django.test.simple import build_doctest_suite
import mymodule

def suite()
    suite = TestSuite()
    suite.addTest(build_doctest_suite(mymodule))
    return suite

[Antti Kaihola]

suggested patch

[Russell Keith-Magee]

This seems like overkill to me. The repetition it removes isn't around a complex block of code that could be a serious maintenance problem - it's a single duplicated function call, with a common set of arguments. If you're building a custom test suite, I would argue that you should be explicitly making a decision on your Doctest arguments; the 'use the same defaults as Django' isn't a strong enough use case in my book.