Opened 17 years ago
Closed 17 years ago
#6134 closed (fixed)
Enhancement to run SQLite unit tests with a database file, rather than in-memory db
Reported by: | jdetaeye | Owned by: | nobody |
---|---|---|---|
Component: | Testing framework | Version: | dev |
Severity: | Keywords: | test sqlite | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
In my application and its test suite I also run an external process to process some data in the database. When using the SQLite database engine I can't use the in-memory database that is: it's only visible inside the python process running the test...
For other database engines, one can use the TEST_DATABASE_NAME to choose the database to use for the tests, but no such override capability is possible with SQLite.
This patch corrects this "unfair" inbalance:
- When no TEST_DATABASE_NAME is specified in the settings file, it defaults to ":memory:", ie current behavior
- If a TEST_DATABASE_NAME setting is present and it's different from ":memory:" we try to delete the database file before running the tests. Similar as the other database engines, the user is prompted for confirmation.
- When the tests have finished, the test database file is deleted.
Since this change is backwards-incompatible, a design decision is required on this ticket.
Attachments (2)
Change History (8)
by , 17 years ago
Attachment: | sqlitetest.patch added |
---|
comment:1 by , 17 years ago
Triage Stage: | Unreviewed → Design decision needed |
---|
comment:2 by , 17 years ago
Needs documentation: | set |
---|---|
Triage Stage: | Design decision needed → Accepted |
Seems reasonable. Needs a patch to the docs of TEST_DATABASE_NAME, but otherwise looks OK.
comment:3 by , 17 years ago
Needs documentation: | unset |
---|
The documentation patch goes a little further than only documenting this settings change.
The documentation on the unit tests described the test database and its settings under the section Understanding the test output. I believe the text is cleared and easier to read when the test database is covered in a seperate section The test database.
Feel free to revise and update further...
comment:4 by , 17 years ago
Triage Stage: | Accepted → Ready for checkin |
---|
comment:5 by , 17 years ago
comment:6 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
patch