Code

Opened 6 years ago

Closed 6 years ago

#6109 closed (fixed)

Fieldset description is autoescaped in admin

Reported by: Øyvind Saltvik <oyvind@…> Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords: autoescaped fieldset
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

http://code.djangoproject.com/browser/django/trunk/django/contrib/admin/templates/admin/change_form.html#L37

Should add a |safe for the description since the docs says it should not be escaped

Attachments (1)

description_autoescape.diff (880 bytes) - added by SomeGuy <SomeGuy@…> 6 years ago.

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by SomeGuy <SomeGuy@…>

comment:1 Changed 6 years ago by SomeGuy <SomeGuy@…>

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 6 years ago by SmileyChris

  • Triage Stage changed from Accepted to Ready for checkin

Yep, the docs clearly state that it shouldn't be escaped: http://www.djangoproject.com/documentation/model-api/#description

comment:3 Changed 6 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [7078]) Fixed #6109 -- Marked fieldset descriptions as safe from auto-escaping. Good
catch, SomeGuy.

comment:4 Changed 6 years ago by lukeplant

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:5 Changed 6 years ago by lukeplant

This is broken again, since newforms-admin was merged I think.

comment:6 Changed 6 years ago by lukeplant

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [8073]) Fixed #6109 again.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.