Opened 8 years ago

Closed 5 years ago

#6096 closed (fixed)

commit_on_success does not handle SystemExit

Reported by: eric@… Owned by: fgallina
Component: Database layer (models, ORM) Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I do not know if commit_on_success intentionally only catches Exception instead of BaseException (or just a plain except:). I was writing a command-line script that called sys.exit(1) when it detected a problem, but the transaction manager was raising TransactionManagementError("Transaction managed block ended with pending COMMIT/ROLLBACK") and it took me a long time to figure out what was going on.

If you don't want to change it to catch all exceptions, may I suggest adding a small note to the docs?

Change History (4)

comment:1 Changed 8 years ago by SmileyChris

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

Yea, sounds like a bug... passing to core to check.

comment:2 Changed 5 years ago by mtredinnick

  • Triage Stage changed from Design decision needed to Accepted

Change this (you can use a bare "except" and just document it). I think this is just a consequence of us old-timers not always remembering SystemEerror got moved outside of Exception in the hierarchy at some point in the last decade. We have more things to remember than you young guys, so be nice to us. :-)

comment:3 Changed 5 years ago by fgallina

  • Owner changed from nobody to fgallina

comment:4 Changed 5 years ago by fgallina

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.
Back to Top