Code

Opened 6 years ago

Closed 6 years ago

#6085 closed (fixed)

separated contrib.auth and contrib.admin views

Reported by: Honza_Kral Owned by: nobody
Component: Uncategorized Version: newforms-admin
Severity: Keywords: auth admin views
Cc: sjulean@… Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

it would make more sense to move stuff from contrib/admin/views/auth.py to contrib.auth.models into the UserAdmin

Attachments (1)

6085.patch (10.6 KB) - added by Honza_Kral 6 years ago.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by Honza_Kral

comment:1 Changed 6 years ago by jkocherhans

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [6811].

comment:2 Changed 6 years ago by sjulean

  • Cc sjulean@… added
  • Patch needs improvement set
  • Resolution fixed deleted
  • Status changed from closed to reopened

The fixes in [6811] and [6812] break the importing of django.contrib.auth.views from a user project that uses django.contrib.admin - I have tried doing that from urls.py (both the one in an application and the project-wide one).

The culprit seems to be a circular import triggered in the django.contrib.auth package: views.py imports forms.py, which imports models.py, which in turn imports admin.py, which imports forms.py again.

comment:3 Changed 6 years ago by Simon Greenhill <dev@…>

  • Resolution set to fixed
  • Status changed from reopened to closed

sjulean, if this is still an issue can you open a new ticket for it? thanks :)

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.