Opened 17 years ago
Closed 17 years ago
#6085 closed (fixed)
separated contrib.auth and contrib.admin views
Reported by: | Honza Král | Owned by: | nobody |
---|---|---|---|
Component: | Uncategorized | Version: | newforms-admin |
Severity: | Keywords: | auth admin views | |
Cc: | sjulean@… | Triage Stage: | Unreviewed |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | no | UI/UX: | no |
Description
it would make more sense to move stuff from contrib/admin/views/auth.py to contrib.auth.models into the UserAdmin
Attachments (1)
Change History (4)
by , 17 years ago
Attachment: | 6085.patch added |
---|
comment:1 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:2 by , 17 years ago
Cc: | added |
---|---|
Patch needs improvement: | set |
Resolution: | fixed |
Status: | closed → reopened |
The fixes in [6811] and [6812] break the importing of django.contrib.auth.views
from a user project that uses django.contrib.admin
- I have tried doing that from urls.py
(both the one in an application and the project-wide one).
The culprit seems to be a circular import triggered in the django.contrib.auth
package: views.py
imports forms.py
, which imports models.py
, which in turn imports admin.py
, which imports forms.py
again.
comment:3 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
sjulean, if this is still an issue can you open a new ticket for it? thanks :)
Fixed in [6811].