Code

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6059 closed (fixed)

newforms-admin extra javascript is getting escaped

Reported by: Karen Tracey <kmtracey@…> Owned by: nobody
Component: contrib.admin Version: newforms-admin
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

On change and add pages, I'm seeing escaped script tags on the top line:

<script type="text/javascript" src="/media/js/core.js"></script> <script type="text/javascript" src="/media/js/admin/RelatedObjectLookups.js"></script>

Attached patch fixes this by marking the 'media' template variable as safe.

Attachments (1)

safe_media.diff (916 bytes) - added by Karen Tracey <kmtracey@…> 7 years ago.

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by Karen Tracey <kmtracey@…>

comment:1 Changed 7 years ago by jkocherhans

  • Resolution set to fixed
  • Status changed from new to closed

(In [6779]) newforms-admin: Fixed #6059. Javascript in the admin is no longer escaped.

comment:2 Changed 7 years ago by jkocherhans

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Oops. Forgot to thank Karen Tracy in the commit message. Sorry Karen, and thanks. :)

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.