Opened 8 years ago

Closed 8 years ago

#6049 closed (fixed)

Tests for changes in r6721

Reported by: SmileyChris Owned by: nobody
Component: Template system Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


Tests for [6721] -- "Fixed an edge-case for auto-escaping: if the stringfilter decorator is used and
generates a first argument that is a safe string, make the is_safe handling
work as expect."

Changes to code without comments or tests? Gosh ;)

Attachments (1)

6721_tests.diff (4.1 KB) - added by SmileyChris 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by SmileyChris

comment:1 Changed 8 years ago by SmileyChris

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 8 years ago by mtredinnick

Your comment additions show why none are required. They're all of the "set i to i+1" form: just rephrasing an obvious line of code in another language. Thanks for the tests, though.

comment:3 Changed 8 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [6729]) Added tests and a small optimisation for [6721]. Thanks SmileyChris. Fixed #6049

Note: See TracTickets for help on using tickets.
Back to Top