Opened 8 years ago

Closed 4 years ago

Last modified 4 years ago

#6011 closed Bug (fixed) flush command not working as advertised

Reported by: Collin Grady <cgrady@…> Owned by: nobody
Component: Core (Management commands) Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


If you run help flush, it indicates that it will be the same as if you ran the sql in sqlflush

However, once you try to run it, it starts prompting as if it's running syncdb, like reset does.

Flush should be a simple flush as advertised, while reset does the resetting.

Attachments (2)

management-flush-helptext.diff (695 bytes) - added by darkpixel 8 years ago.
Updated help text for flush command
6011.flush-help.diff (882 bytes) - added by julien 4 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Flush is intended to return the database to a post-sync state. It is used extensively by the testing system for this reason. In this case, the documentation is at fault and the behaviour is correct.

Reset operates on a per-app basis. As a result, cross-app references really mess with the reset command. I have mentioned a few times that I think reset should be deprecated, but we probably won't do so until such time as a schema evolution approach is introduced to trunk.

Changed 8 years ago by darkpixel

Updated help text for flush command

comment:2 Changed 8 years ago by darkpixel

  • Has patch set

Updated help text for flush

comment:3 Changed 5 years ago by gabrielhurley

  • Severity set to Normal
  • Type set to Bug

Changed 4 years ago by julien

comment:4 Changed 4 years ago by julien

  • Easy pickings unset

Simply replaced the help text with the one that's in the doc.

comment:5 Changed 4 years ago by ptone

  • Triage Stage changed from Accepted to Ready for checkin
  • UI/UX unset

Assuming Julien was not core-dev when this patch was attached.

comment:6 Changed 4 years ago by PaulM

  • Resolution set to fixed
  • Status changed from new to closed

In [16877]:

Fixed #6011 -- Improved help text for flush command. Thanks Julien for the patch.

Note: See TracTickets for help on using tickets.
Back to Top