Opened 16 years ago

Closed 16 years ago

Last modified 12 years ago

#6004 closed (fixed)

Useless code in newforms admin

Reported by: Petr Marhoun <petr.marhoun@…> Owned by: nobody
Component: contrib.admin Version: newforms-admin
Severity: Keywords: nfa-blocker
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

There is too much not used code in newforms admin. It is quite difficult to understand django.contrib.admin if there are many obsolete things. I don't feel it is useful as documentation - there are too many changes and almost everything is ported now.

For example:

  • urls.py - replaced by sites.ModelAdmin.root and options.ModelAdmin.call
  • templates.widget - replaced by widgets.py
  • almost everything in templatetags.admin_modify and views.main.AdminBoundField - replaced by widgets.py and wrappers from options
  • views.main.model_admin_view and views.main.index - moved to sites.ModelAdmin

Attachments (4)

00-admin-useless-code.diff (10.5 KB ) - added by Petr Marhoun <petr.marhoun@…> 16 years ago.
00-admin-useless-code.2.diff (10.5 KB ) - added by Petr Marhoun <petr.marhoun@…> 16 years ago.
00-admin-useless-code.3.diff (10.5 KB ) - added by Petr Marhoun <petr.marhoun@…> 16 years ago.
new version - after autoescape merge
00-admin-useless-code.4.diff (10.6 KB ) - added by Jeff Anderson 16 years ago.

Download all attachments as: .zip

Change History (12)

by Petr Marhoun <petr.marhoun@…>, 16 years ago

Attachment: 00-admin-useless-code.diff added

by Petr Marhoun <petr.marhoun@…>, 16 years ago

comment:1 by Petr Marhoun <petr.marhoun@…>, 16 years ago

I don't know why but my patch is not showed by trac. It can be download as original format.

by Petr Marhoun <petr.marhoun@…>, 16 years ago

new version - after autoescape merge

comment:2 by Karen Tracey <kmtracey@…>, 16 years ago

Keywords: nfa-blocker added

I think it would make sense to clean things up before merge, so I'm marking this blocking. TPTB can of course feel free to disagree & override.

comment:3 by MichaelBishop, 16 years ago

Triage Stage: UnreviewedDesign decision needed

Decision needed - it's been 4 months since these diff's were submitted, perhaps they are no longer relevant to the currnt SVN branch of NFA?

comment:4 by Marc Garcia, 16 years ago

milestone: 1.0 alpha

by Jeff Anderson, 16 years ago

comment:5 by Jeff Anderson, 16 years ago

Updated patch to apply cleanly.

comment:6 by Jeff Anderson, 16 years ago

Triage Stage: Design decision neededReady for checkin

comment:7 by Luke Plant, 16 years ago

Resolution: fixed
Status: newclosed

Fixed in r7736

comment:8 by Jacob, 12 years ago

milestone: 1.0 alpha

Milestone 1.0 alpha deleted

Note: See TracTickets for help on using tickets.
Back to Top