Code

Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#6004 closed (fixed)

Useless code in newforms admin

Reported by: Petr Marhoun <petr.marhoun@…> Owned by: nobody
Component: contrib.admin Version: newforms-admin
Severity: Keywords: nfa-blocker
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

There is too much not used code in newforms admin. It is quite difficult to understand django.contrib.admin if there are many obsolete things. I don't feel it is useful as documentation - there are too many changes and almost everything is ported now.

For example:

  • urls.py - replaced by sites.ModelAdmin.root and options.ModelAdmin.call
  • templates.widget - replaced by widgets.py
  • almost everything in templatetags.admin_modify and views.main.AdminBoundField - replaced by widgets.py and wrappers from options
  • views.main.model_admin_view and views.main.index - moved to sites.ModelAdmin

Attachments (4)

00-admin-useless-code.diff (10.5 KB) - added by Petr Marhoun <petr.marhoun@…> 6 years ago.
00-admin-useless-code.2.diff (10.5 KB) - added by Petr Marhoun <petr.marhoun@…> 6 years ago.
00-admin-useless-code.3.diff (10.5 KB) - added by Petr Marhoun <petr.marhoun@…> 6 years ago.
new version - after autoescape merge
00-admin-useless-code.4.diff (10.6 KB) - added by programmerq 6 years ago.

Download all attachments as: .zip

Change History (12)

Changed 6 years ago by Petr Marhoun <petr.marhoun@…>

Changed 6 years ago by Petr Marhoun <petr.marhoun@…>

comment:1 Changed 6 years ago by Petr Marhoun <petr.marhoun@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

I don't know why but my patch is not showed by trac. It can be download as original format.

Changed 6 years ago by Petr Marhoun <petr.marhoun@…>

new version - after autoescape merge

comment:2 Changed 6 years ago by Karen Tracey <kmtracey@…>

  • Keywords nfa-blocker added

I think it would make sense to clean things up before merge, so I'm marking this blocking. TPTB can of course feel free to disagree & override.

comment:3 Changed 6 years ago by MichaelBishop

  • Triage Stage changed from Unreviewed to Design decision needed

Decision needed - it's been 4 months since these diff's were submitted, perhaps they are no longer relevant to the currnt SVN branch of NFA?

comment:4 Changed 6 years ago by garcia_marc

  • milestone set to 1.0 alpha

Changed 6 years ago by programmerq

comment:5 Changed 6 years ago by programmerq

Updated patch to apply cleanly.

comment:6 Changed 6 years ago by programmerq

  • Triage Stage changed from Design decision needed to Ready for checkin

comment:7 Changed 6 years ago by lukeplant

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r7736

comment:8 Changed 3 years ago by jacob

  • milestone 1.0 alpha deleted

Milestone 1.0 alpha deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.