Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#5999 closed (fixed)

Broken expired session in newforms-admin

Reported by: Petr Marhoun <petr.marhoun@…> Owned by: Mnewman
Component: contrib.admin Version: newforms-admin
Severity: Keywords: nfa-blocker
Cc: purdeaandrei@…, favo@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

If session expires in newforms-admin (try to remove everything from django_session table), non-existing method view_func is called.

Attachments (4)

00-admin-expired-session.diff (1.1 KB) - added by Petr Marhoun <petr.marhoun@…> 8 years ago.
alternative.diff (756 bytes) - added by purdeaandrei 7 years ago.
alternative2.diff (1.0 KB) - added by favo <favo@…> 7 years ago.
nfa-expired-session-5999.patch (2.4 KB) - added by Mnewman 7 years ago.
New patch with tests, applied against r7609

Download all attachments as: .zip

Change History (13)

Changed 8 years ago by Petr Marhoun <petr.marhoun@…>

comment:1 Changed 8 years ago by brosner

  • Keywords nfa-blocker added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

Looks good to me. This is a critical fix that needs to be in newforms-admin before a merge.

Changed 7 years ago by purdeaandrei

comment:2 Changed 7 years ago by purdeaandrei

  • Cc purdeaandrei@… added

i also added an alternative

comment:3 follow-up: Changed 7 years ago by brosner

  • Triage Stage changed from Ready for checkin to Accepted

We will be rewriting the URL handling in newforms-admin making this patch obsolete. Bumping down to Accepted so we don't forget about this edge case.

comment:4 Changed 7 years ago by favo <favo@…>

  • Cc favo@… added

Changed 7 years ago by favo <favo@…>

comment:5 in reply to: ↑ 3 Changed 7 years ago by favo <favo@…>

Replying to brosner:

We will be rewriting the URL handling in newforms-admin making this patch obsolete. Bumping down to Accepted so we don't forget about this edge case.

Hope we can still got benefit from django naming URL.

comment:6 Changed 7 years ago by Mnewman

  • Needs tests set
  • Owner changed from nobody to Mnewman

Changed 7 years ago by Mnewman

New patch with tests, applied against r7609

comment:7 Changed 7 years ago by Mnewman

  • Needs tests unset

Tests are added. I liked the way favo changed the login method to expect persistent data.

comment:8 Changed 7 years ago by brosner

  • Resolution set to fixed
  • Status changed from new to closed

(In [7611]) newforms-admin: Fixed #5999 -- When a session expires properly route the flow to call the correct view. Thanks favo and Michael Newman.

comment:9 Changed 7 years ago by bocman1 <Bocman1@…>

Note: See TracTickets for help on using tickets.
Back to Top