#5999 closed (fixed)
Broken expired session in newforms-admin
Reported by: | Owned by: | Michael Newman | |
---|---|---|---|
Component: | contrib.admin | Version: | newforms-admin |
Severity: | Keywords: | nfa-blocker | |
Cc: | purdeaandrei@…, favo@… | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
If session expires in newforms-admin (try to remove everything from django_session table), non-existing method view_func is called.
Attachments (4)
Change History (13)
by , 17 years ago
Attachment: | 00-admin-expired-session.diff added |
---|
comment:1 by , 17 years ago
Keywords: | nfa-blocker added |
---|---|
Triage Stage: | Unreviewed → Ready for checkin |
by , 17 years ago
Attachment: | alternative.diff added |
---|
follow-up: 5 comment:3 by , 17 years ago
Triage Stage: | Ready for checkin → Accepted |
---|
We will be rewriting the URL handling in newforms-admin making this patch obsolete. Bumping down to Accepted so we don't forget about this edge case.
comment:4 by , 17 years ago
Cc: | added |
---|
by , 17 years ago
Attachment: | alternative2.diff added |
---|
comment:5 by , 17 years ago
Replying to brosner:
We will be rewriting the URL handling in newforms-admin making this patch obsolete. Bumping down to Accepted so we don't forget about this edge case.
Hope we can still got benefit from django naming URL.
comment:6 by , 17 years ago
Needs tests: | set |
---|---|
Owner: | changed from | to
by , 17 years ago
Attachment: | nfa-expired-session-5999.patch added |
---|
New patch with tests, applied against r7609
comment:7 by , 17 years ago
Needs tests: | unset |
---|
Tests are added. I liked the way favo changed the login method to expect persistent data.
comment:8 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Looks good to me. This is a critical fix that needs to be in newforms-admin before a merge.