Opened 17 years ago

Closed 17 years ago

Last modified 17 years ago

#5999 closed (fixed)

Broken expired session in newforms-admin

Reported by: Petr Marhoun <petr.marhoun@…> Owned by: Michael Newman
Component: contrib.admin Version: newforms-admin
Severity: Keywords: nfa-blocker
Cc: purdeaandrei@…, favo@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

If session expires in newforms-admin (try to remove everything from django_session table), non-existing method view_func is called.

Attachments (4)

00-admin-expired-session.diff​ (1.1 KB ) - added by Petr Marhoun <petr.marhoun@…> 17 years ago.
alternative.diff​ (756 bytes ) - added by Purdea Andrei 17 years ago.
alternative2.diff​ (1.0 KB ) - added by favo <favo@…> 17 years ago.
nfa-expired-session-5999.patch​ (2.4 KB ) - added by Michael Newman 17 years ago.
New patch with tests, applied against r7609

Download all attachments as: .zip

Change History (13)

by Petr Marhoun <petr.marhoun@…>, 17 years ago

Attachment: 00-admin-expired-session.diff​ added

comment:1 by Brian Rosner, 17 years ago

Keywords: nfa-blocker added
Triage Stage: Unreviewed → Ready for checkin

Looks good to me. This is a critical fix that needs to be in newforms-admin before a merge.

by Purdea Andrei, 17 years ago

Attachment: alternative.diff​ added

comment:2 by Purdea Andrei, 17 years ago

Cc: purdeaandrei@… added

i also added an alternative

comment:3 by Brian Rosner, 17 years ago

Triage Stage: Ready for checkin → Accepted

We will be rewriting the URL handling in newforms-admin making this patch obsolete. Bumping down to Accepted so we don't forget about this edge case.

comment:4 by favo <favo@…>, 17 years ago

Cc: favo@… added

by favo <favo@…>, 17 years ago

Attachment: alternative2.diff​ added

in reply to:  3 comment:5 by favo <favo@…>, 17 years ago

Replying to brosner:

We will be rewriting the URL handling in newforms-admin making this patch obsolete. Bumping down to Accepted so we don't forget about this edge case.

Hope we can still got benefit from django naming URL.

comment:6 by Michael Newman, 17 years ago

Needs tests: set
Owner: changed from nobody to Michael Newman

by Michael Newman, 17 years ago

Attachment: nfa-expired-session-5999.patch​ added

New patch with tests, applied against r7609

comment:7 by Michael Newman, 17 years ago

Needs tests: unset

Tests are added. I liked the way favo changed the login method to expect persistent data.

comment:8 by Brian Rosner, 17 years ago

Resolution: → fixed
Status: new → closed

(In [7611]) newforms-admin: Fixed #5999 -- When a session expires properly route the flow to call the correct view. Thanks favo and Michael Newman.

comment:9 by bocman1 <Bocman1@…>, 17 years ago

​http://www.dizmex.com

Note: See TracTickets for help on using tickets.
Back to Top