Code

Opened 6 years ago

Closed 6 years ago

#5991 closed (fixed)

Auto-escaping patch, fix for SelectDateWidget

Reported by: alberto.piai@… Owned by: nobody
Component: Forms Version: master
Severity: Keywords: newforms, selectdatewidget, auto-escaping
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

SelectDateWidget from newform extras stopped working after
autoescaping was introduced in r6671. Here is the tiny patch to fix
it.

Attachments (2)

fix-SelectDateWidget-after-autoescaping.diff (816 bytes) - added by alberto.piai@… 6 years ago.
fix-SelectDateWidget-after-autoescaping.2.diff (816 bytes) - added by alberto.piai@… 6 years ago.
Trying again, for some reason it wasn't uploaded…

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by alberto.piai@…

Changed 6 years ago by alberto.piai@…

Trying again, for some reason it wasn't uploaded...

comment:1 Changed 6 years ago by alberto.piai@…

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

For some reasons the patch isn't displayed at all... but the file is there (twice, just ignore one), download it in original format.
Am I doing something wrong?

Thanks,
Alberto

comment:2 Changed 6 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [6723]) Fixed #5991 -- Marked the generated HTML for newforms.extra.SelectDateWidget as
safe. Patch from alberto.piai@….

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.