Code

Opened 6 years ago

Closed 6 years ago

#5978 closed (fixed)

LOCALE_PATHS setting does not default to an empty tuple like the docs mention

Reported by: gwilson Owned by: nobody
Component: Translations Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The documentation note was added in [6534], but there is no LOCALE_PATHS in django/conf/global_settings.py. If a default setting is added, a bit of code in a couple other places could be removed since it is making up for the fact that there might not be a default setting. Is this what we want to do Malcolm?

Attachments (1)

5978.diff (2.3 KB) - added by gwilson 6 years ago.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by gwilson

comment:1 Changed 6 years ago by gwilson

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

comment:2 Changed 6 years ago by mtredinnick

  • Triage Stage changed from Design decision needed to Ready for checkin

Sounds good. Go for it.

comment:3 Changed 6 years ago by gwilson

  • Resolution set to fixed
  • Status changed from new to closed

(In [6701]) Fixed #5978 -- Gave LOCALE_PATHS a default setting of an empty tuple and removed some code that was checking for its existance in settings before accessing it.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.