django.template.TokenParser inconsistent with parsing filters

[Dmitri Fedortchenko <zeraien@…>]

django.template.TokenParser is inconsistent
when parsing filters that follow constant strings or variables.

Meaning that:

{% tag thevar|filter sometag %}

will produce:

self.value() = "thevar|filter"
self.tag() = "sometag"

However:

{% tag "a value"|filter sometag %}

will produce:

self.value() = "a value"
self.tag() = "|filter"
self.tag() = "sometag"

This does not seem like correct behaviour...
I made a very simple patch for this, thus the outcome of the above:

{% tag "a value"|filter sometag %}

will produce:

value = "a value"|filter
tag = sometag

So now we can simply pass the "value" into a FilterExpression to parse the filters...

PS: I had trouble naming an internal method, feel free to complain about the name ;)

[Dmitri Fedortchenko <zeraien@…>]

The patch

[Dmitri Fedortchenko <zeraien@…>]

django.template.TokenParser is inconsistent when parsing filters that follow constant strings or variables.

Meaning that {% tag thevar|filter sometag %} will produce:

self.value() = "thevar|filter"
self.tag() = "sometag"

However {% tag "a value"|filter sometag %} will produce:

self.value() = "a value"
self.tag() = "|filter"
self.tag() = "sometag"

This does not seem like correct behaviour... I made a very simple patch for this, thus the outcome of the above:

{% tag "a value"|filter sometag %} will produce:
self.value() = "a value"|filter
self.tag() = sometag

So now we can simply pass the "value" into a FilterExpression? to parse the filters...

See this thread:
​http://groups.google.com/group/django-developers/browse_thread/thread/c90b6e29d20724ca

PS: I should learn to use the preview button.
PPS: The self is from the perspective of the implementee of the TokenParser class.

[Malcolm Tredinnick]

Fixed description formatting.

[Ramiro Morales]

Unified and updated patches (implementation bt Dmitri Fedortchenko and tests by adamv)

[Ramiro Morales]

Patch updated to port r10118

[Ramiro Morales]

I've update the patch to expand regressiontests/template/parser.py (added in r10118) rather than adding a regressiontests/tokenparser/ subdir.

While at it, also made sure the variable_parsing doctests get executed, they had been added in that revision but weren't being run.

[Jannis Leidel]

(In [12471]) Fixed #5971 - Fixed inconsistent behaviour of the TokenParser when parsing filters that follow constant strings or variables. Thanks Dmitri Fedortchenko, Adam Vandenberg and Ramiro Morales.