Code

Opened 6 years ago

Closed 6 years ago

#5947 closed (invalid)

Minimal MS Sql Server patch for syncdb

Reported by: adamv Owned by: adamv
Component: Database layer (models, ORM) Version: master
Severity: Keywords: sqlserver
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

There are a lot of open bugs for improving SQL Server support in Django.
Eventually I want to help on the task that's migrating from adodbapi, but I needed something that "works now".

I've included a MINIMAL patch for the existing ado_mssql backend: It fixes the %s/? parameter issue and includes a bare-bones table inspector.
(It does not address LIMIT/TOP, time resolution, etc.)

Basically, this allows a "manage.py syncdb" to run against this backend, and create the default auth_/django_ tables and insert data, something that trunk wasn't doing for me.

I'd love to add any tests this patch needs, if someone can point me to how to get the unit tests running.

Attachments (1)

minimal_sql2005_syncdb.patch (2.1 KB) - added by adamv 6 years ago.

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by adamv

comment:1 Changed 6 years ago by adamv

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to adamv
  • Patch needs improvement unset

(Consider me "very interested" in doing some SQL Server work during the Dec 1 sprint.)

comment:2 Changed 6 years ago by mtredinnick

It's probably a better approach to create whatever backend you like out of tree and then we can consider incorporating it later. We're very unlikely at this point to include any SQL Server patches without somebody already having an extended history of supporting them, so having yet another ticket open for SQL Server support, although well intentioned, isn't really making any progress.

Please consider starting a google code project (or some other form of hosting) for your backend as an out of tree backend (no patches against trunk). See #1261 for a similar case for Firebird. The same logic applies here.

Not discouraging you from building SQL Server support, but patches like this aren't going to land in trunk without a track record, particularly given all the changes to SQL generation coming up in the near future.

Please close this ticket once the backend is available somewhere.

comment:3 Changed 6 years ago by adamv

Project is online here:

I'll be closing this bug soon (hopefully over the weekend), but first I'm going to comb the existing SQL Server bugs/patches for low hanging fruit.

comment:4 Changed 6 years ago by adamv

  • Resolution set to invalid
  • Status changed from new to closed

Resolving; work is now happening over on Google Code.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.