Opened 9 years ago

Closed 9 years ago

#5939 closed (fixed)

Localflavor: Canadian province normalization omits New Brunswick

Reported by: rajesh.dhawan@… Owned by: Rajesh Dhawan
Component: contrib.localflavor Version: master
Severity: Keywords: canada province new-brunswick
Cc: rajesh.dhawan@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

A mapping for nb (New Brunswick) is missing in PROVINCES_NORMALIZED in django/contrib/localflavor/ca/ca_provinces.py

This causes django.contrib.localflavor.ca.forms.CAProvinceField to not accept NB as a valid Canadian Province.

Attachments (2)

ca_provinces.diff (447 bytes) - added by rajesh.dhawan@… 9 years ago.
Patch to add the missing mapping for "NB"
ca_provinces.2.diff (925 bytes) - added by Rajesh Dhawan 9 years ago.
Better patch to add the missing mapping for "NB" as well as a couple of regression tests

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by rajesh.dhawan@…

Attachment: ca_provinces.diff added

Patch to add the missing mapping for "NB"

comment:1 Changed 9 years ago by Rajesh Dhawan

Owner: changed from nobody to Rajesh Dhawan
Status: newassigned

Changed 9 years ago by Rajesh Dhawan

Attachment: ca_provinces.2.diff added

Better patch to add the missing mapping for "NB" as well as a couple of regression tests

comment:2 Changed 9 years ago by Rajesh Dhawan

Triage Stage: UnreviewedReady for checkin

comment:3 Changed 9 years ago by Malcolm Tredinnick

Resolution: fixed
Status: assignedclosed

Fixed in [6744].

Note: See TracTickets for help on using tickets.
Back to Top