Code

Opened 6 years ago

Closed 6 years ago

#5939 closed (fixed)

Localflavor: Canadian province normalization omits New Brunswick

Reported by: rajesh.dhawan@… Owned by: rajeshdhawan
Component: contrib.localflavor Version: master
Severity: Keywords: canada province new-brunswick
Cc: rajesh.dhawan@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

A mapping for nb (New Brunswick) is missing in PROVINCES_NORMALIZED in django/contrib/localflavor/ca/ca_provinces.py

This causes django.contrib.localflavor.ca.forms.CAProvinceField to not accept NB as a valid Canadian Province.

Attachments (2)

ca_provinces.diff (447 bytes) - added by rajesh.dhawan@… 6 years ago.
Patch to add the missing mapping for "NB"
ca_provinces.2.diff (925 bytes) - added by rajeshdhawan 6 years ago.
Better patch to add the missing mapping for "NB" as well as a couple of regression tests

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by rajesh.dhawan@…

Patch to add the missing mapping for "NB"

comment:1 Changed 6 years ago by rajeshdhawan

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to rajeshdhawan
  • Patch needs improvement unset
  • Status changed from new to assigned

Changed 6 years ago by rajeshdhawan

Better patch to add the missing mapping for "NB" as well as a couple of regression tests

comment:2 Changed 6 years ago by rajeshdhawan

  • Triage Stage changed from Unreviewed to Ready for checkin

comment:3 Changed 6 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in [6744].

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.