__repr__ for db Fields

[Thomas Güttler <hv@…>]

Hi,

for debugging it is usefull, if repr(mydbfield) displays the name
of the field. Small patch inclusive test attached.

[Malcolm Tredinnick]

Seems reasonable. However, the test doesn't show that it works as expected. It shows that when you use a field in a completely non-standard fashion (outside of a model), it reports None. That's maybe 0.001% of the normal use-cases. Testing the other 99%+ would be ideal. :-)

[Johannes Dollinger]

added a test

[Julien Phalip]

This looks great but it'd be even better if the tests also covered the 0.001% of use cases (i.e. when the field does not have a name) :-)

[Mathieu Agopian]

Here is an updated patch that applies on the current trunk.

I believe there's no way a django.db.models.fields.Field won't have a name anymore though.

[Mathieu Agopian]

updated patch that applies to the current trunk

[Claude Paroz]

I think that Julien's comment was referring to a test like:

from django.db.model.fields import CharField
my_field = CharField()
repr(my_field)

that should reveal the None value in place of the name.

[Julien Phalip]

Replying to claudep:

I think that Julien's comment was referring to a test like:

from django.db.model.fields import CharField
my_field = CharField()
repr(my_field)

that should reveal the None value in place of the name.

That's correct. There's nothing preventing you from using a Field on its own, hence the "getattr(self, 'name', None))" in the patch ;)

[Julien Phalip]

That said, I also think that <django.db.models.fields.CharField None> would be rather confusing. If the field doesn't have a name, then simply displaying <django.db.models.fields.CharField> would be preferable in my opinion.

[Mathieu Agopian]

updated patch taking claudep's and julien's comments into account

[Mathieu Agopian]

I understand now ;) thanks for the feedbacks and comments!

I've attached an updated patch, with the additional test and the specific case for the Field instantiated without a name.

Please let me know if this needs further improvements!

[Jannis Leidel]

In [16145]:

Fixed #5931 -- Added repr to db fields. Thanks, Thomas Güttler, emulbreh and magopian.