Opened 16 years ago

Last modified 2 years ago

#5899 new New feature

Allow admin fieldsets to be collapsible but not initially collapsed

Reported by: Ionut Ciocirlan <ionut.ciocirlan@…> Owned by:
Component: contrib.admin Version: newforms-admin
Severity: Normal Keywords: admin fieldset collapsed collapsible nfa-someday
Cc: cmawebsite@…, olivier.dalang@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

I want to use the collapse feature of the admin, but not have the field initially collapsed, so I made this little patch.

It adds a "collapsible" class that does just that. It also patches the documentation.

Attachments (4)

django.collapsible_fieldset.diff​ (5.2 KB ) - added by Ionut Ciocirlan <ionut.ciocirlan@…> 16 years ago.
django_newforms-admin.collapsible_fieldset.diff​ (5.2 KB ) - added by Ionut Ciocirlan <ionut.ciocirlan@…> 16 years ago.
5899.diff​ (8.7 KB ) - added by Alexander Herrmann 13 years ago.
5899.collapsible-fieldsets.diff​ (8.6 KB ) - added by Julien Phalip 13 years ago.

Download all attachments as: .zip

Change History (17)

by Ionut Ciocirlan <ionut.ciocirlan@…>, 16 years ago

Attachment: django.collapsible_fieldset.diff​ added

comment:1 by Brian Rosner, 16 years ago

Patch needs improvement: set
Triage Stage: Unreviewed → Accepted
Version: SVN → newforms-admin

I am +1 on this. However, the trunk admin is longer being supported. Ionut, can you provide a patch against the newforms-admin branch?

by Ionut Ciocirlan <ionut.ciocirlan@…>, 16 years ago

Attachment: django_newforms-admin.collapsible_fieldset.diff​ added

comment:2 by Ionut Ciocirlan <ionut.ciocirlan@…>, 16 years ago

Patch needs improvement: unset

Done, attached new patch.

comment:3 by Karen Tracey <kmtracey@…>, 16 years ago

Keywords: nfa-someday added

New function, should not block merge.

comment:4 by Gabriel Hurley, 13 years ago

Severity: → Normal
Type: → New feature

comment:5 by patchhammer, 13 years ago

Easy pickings: unset
Patch needs improvement: set

django_newforms-admin.collapsible_fieldset.diff fails to apply cleanly on to trunk

comment:6 by Julien Phalip, 13 years ago

UI/UX: set

comment:7 by Alexander Herrmann, 13 years ago

Owner: changed from nobody to Alexander Herrmann
Status: new → assigned

by Alexander Herrmann, 13 years ago

Attachment: 5899.diff​ added

comment:8 by Alexander Herrmann, 13 years ago

Patch needs improvement: unset

I implemented the suggested behaviour to the current trunk, see 5899.diff.

by Julien Phalip, 13 years ago

Attachment: 5899.collapsible-fieldsets.diff​ added

comment:9 by Julien Phalip, 13 years ago

The patch looks great, I've just updated it to current trunk. I'd be tempted to RFC this patch even if it doesn't contain tests. There are no plans on implementing a framework for testing the admin *interface* (as opposed to regular javascript code) clearly spelled out yet, even in #16193.

comment:10 by Jannis Leidel, 12 years ago

Needs tests: set

Now that we have selenium based interface testing this patch could be expanded with that.

comment:11 by Collin Anderson, 9 years ago

Cc: cmawebsite@… added

Why not simply have all fieldsets collapsable by default and only have them initially collapsed when the "collapse" class is present?

comment:12 by Olivier Dalang, 8 years ago

Cc: olivier.dalang@… added

comment:13 by Mariusz Felisiak, 2 years ago

Owner: Alexander Herrmann removed
Status: assigned → new
Note: See TracTickets for help on using tickets.
Back to Top