Code

Opened 6 years ago

Last modified 21 months ago

#5899 assigned New feature

Allow admin fieldsets to be collapsible but not initially collapsed

Reported by: Ionut Ciocirlan <ionut.ciocirlan@…> Owned by: dArignac
Component: contrib.admin Version: newforms-admin
Severity: Normal Keywords: admin fieldset collapsed collapsible nfa-someday
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

I want to use the collapse feature of the admin, but not have the field initially collapsed, so I made this little patch.

It adds a "collapsible" class that does just that. It also patches the documentation.

Attachments (4)

django.collapsible_fieldset.diff (5.2 KB) - added by Ionut Ciocirlan <ionut.ciocirlan@…> 6 years ago.
django_newforms-admin.collapsible_fieldset.diff (5.2 KB) - added by Ionut Ciocirlan <ionut.ciocirlan@…> 6 years ago.
5899.diff (8.7 KB) - added by dArignac 3 years ago.
5899.collapsible-fieldsets.diff (8.6 KB) - added by julien 3 years ago.

Download all attachments as: .zip

Change History (14)

Changed 6 years ago by Ionut Ciocirlan <ionut.ciocirlan@…>

comment:1 Changed 6 years ago by brosner

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted
  • Version changed from SVN to newforms-admin

I am +1 on this. However, the trunk admin is longer being supported. Ionut, can you provide a patch against the newforms-admin branch?

Changed 6 years ago by Ionut Ciocirlan <ionut.ciocirlan@…>

comment:2 Changed 6 years ago by Ionut Ciocirlan <ionut.ciocirlan@…>

  • Patch needs improvement unset

Done, attached new patch.

comment:3 Changed 6 years ago by Karen Tracey <kmtracey@…>

  • Keywords nfa-someday added

New function, should not block merge.

comment:4 Changed 3 years ago by gabrielhurley

  • Severity set to Normal
  • Type set to New feature

comment:5 Changed 3 years ago by patchhammer

  • Easy pickings unset
  • Patch needs improvement set

django_newforms-admin.collapsible_fieldset.diff fails to apply cleanly on to trunk

comment:6 Changed 3 years ago by julien

  • UI/UX set

comment:7 Changed 3 years ago by dArignac

  • Owner changed from nobody to dArignac
  • Status changed from new to assigned

Changed 3 years ago by dArignac

comment:8 Changed 3 years ago by dArignac

  • Patch needs improvement unset

I implemented the suggested behaviour to the current trunk, see 5899.diff.

Changed 3 years ago by julien

comment:9 Changed 3 years ago by julien

The patch looks great, I've just updated it to current trunk. I'd be tempted to RFC this patch even if it doesn't contain tests. There are no plans on implementing a framework for testing the admin *interface* (as opposed to regular javascript code) clearly spelled out yet, even in #16193.

comment:10 Changed 21 months ago by jezdez

  • Needs tests set

Now that we have selenium based interface testing this patch could be expanded with that.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as assigned
The owner will be changed from dArignac to anonymous. Next status will be 'assigned'
The ticket will be disowned. Next status will be 'new'
as The resolution will be set. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.