Opened 9 years ago

Closed 9 years ago

#5894 closed (fixed)

FilePathField needs to be updated to newforms

Reported by: Alex Gaynor Owned by: Jacob
Component: Forms Version: master
Severity: Keywords: FilePathField
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

FilePathField still Old Forms in newforms-admin

Attachments (11)

diff.diff (2.2 KB) - added by Alex Gaynor 9 years ago.
Newforms didn't have a filepath field, so I have created one, this should be the first step to fixing the admin, I think
diff.2.diff (1.1 KB) - added by Alex Gaynor 9 years ago.
Here is the admin field
diff.3.diff (3.2 KB) - added by Alex Gaynor 9 years ago.
Both diffs in one!
diff.4.diff (3.1 KB) - added by Alex Gaynor 9 years ago.
Putting the max_length back into kwargs
diff.5.diff (3.9 KB) - added by Alex Gaynor 9 years ago.
Adds docs, fixes a few small things
diff.6.diff (5.3 KB) - added by Alex Gaynor 9 years ago.
diff.7.diff (5.3 KB) - added by Alex Gaynor 9 years ago.
Fixes a stupid typo from the previous version
diff.8.diff (5.3 KB) - added by Alex Gaynor 9 years ago.
Fixed the tests
diff.9.diff (5.5 KB) - added by Alex Gaynor 9 years ago.
Refixed the tests, and made the patch more PEP8(thanks brosner)
diff.10.diff (6.3 KB) - added by Alex Gaynor 9 years ago.
Added 2 more test cases
diff.11.diff (6.3 KB) - added by Alex Gaynor 9 years ago.
Fixed a bug introduced last patch

Download all attachments as: .zip

Change History (19)

Changed 9 years ago by Alex Gaynor

Attachment: diff.diff added

Newforms didn't have a filepath field, so I have created one, this should be the first step to fixing the admin, I think

comment:1 Changed 9 years ago by Alex Gaynor

Has patch: set
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

Changed 9 years ago by Alex Gaynor

Attachment: diff.2.diff added

Here is the admin field

comment:2 Changed 9 years ago by Brian Rosner

Component: Admin interfacedjango.newforms
Keywords: newforms-admin removed
Patch needs improvement: set
Summary: FilePathField still uses Old Forms in newforms-adminFilePathField needs to be updated to newforms
Version: newforms-adminSVN

This is actually a bug in newforms and not just newforms-admin. newforms-admin is effected because it uses newforms in the admin.

Changed 9 years ago by Alex Gaynor

Attachment: diff.3.diff added

Both diffs in one!

Changed 9 years ago by Alex Gaynor

Attachment: diff.4.diff added

Putting the max_length back into kwargs

comment:3 Changed 9 years ago by Chris Beaven

Needs documentation: set
Needs tests: set
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

Changed 9 years ago by Alex Gaynor

Attachment: diff.5.diff added

Adds docs, fixes a few small things

comment:4 Changed 9 years ago by Alex Gaynor

Needs documentation: unset

Changed 9 years ago by Alex Gaynor

Attachment: diff.6.diff added

comment:5 Changed 9 years ago by Alex Gaynor

Needs tests: unset

There are now tests.

Changed 9 years ago by Alex Gaynor

Attachment: diff.7.diff added

Fixes a stupid typo from the previous version

Changed 9 years ago by Alex Gaynor

Attachment: diff.8.diff added

Fixed the tests

Changed 9 years ago by Alex Gaynor

Attachment: diff.9.diff added

Refixed the tests, and made the patch more PEP8(thanks brosner)

Changed 9 years ago by Alex Gaynor

Attachment: diff.10.diff added

Added 2 more test cases

Changed 9 years ago by Alex Gaynor

Attachment: diff.11.diff added

Fixed a bug introduced last patch

comment:6 Changed 9 years ago by Brian Rosner

Triage Stage: AcceptedReady for checkin

comment:7 Changed 9 years ago by Jacob

Owner: changed from nobody to Jacob

comment:8 Changed 9 years ago by Jacob

Resolution: fixed
Status: newclosed

(In [7323]) Fixed #5894: added FilePathField to newforms. Thanks, Alex Gaynor.

Note: See TracTickets for help on using tickets.
Back to Top