Opened 8 years ago

Closed 7 years ago

#5894 closed (fixed)

FilePathField needs to be updated to newforms

Reported by: Alex Owned by: jacob
Component: Forms Version: master
Severity: Keywords: FilePathField
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

FilePathField still Old Forms in newforms-admin

Attachments (11)

diff.diff (2.2 KB) - added by Alex 8 years ago.
Newforms didn't have a filepath field, so I have created one, this should be the first step to fixing the admin, I think
diff.2.diff (1.1 KB) - added by Alex 8 years ago.
Here is the admin field
diff.3.diff (3.2 KB) - added by Alex 8 years ago.
Both diffs in one!
diff.4.diff (3.1 KB) - added by Alex 8 years ago.
Putting the max_length back into kwargs
diff.5.diff (3.9 KB) - added by Alex 8 years ago.
Adds docs, fixes a few small things
diff.6.diff (5.3 KB) - added by Alex 8 years ago.
diff.7.diff (5.3 KB) - added by Alex 8 years ago.
Fixes a stupid typo from the previous version
diff.8.diff (5.3 KB) - added by Alex 8 years ago.
Fixed the tests
diff.9.diff (5.5 KB) - added by Alex 8 years ago.
Refixed the tests, and made the patch more PEP8(thanks brosner)
diff.10.diff (6.3 KB) - added by Alex 8 years ago.
Added 2 more test cases
diff.11.diff (6.3 KB) - added by Alex 8 years ago.
Fixed a bug introduced last patch

Download all attachments as: .zip

Change History (19)

Changed 8 years ago by Alex

Newforms didn't have a filepath field, so I have created one, this should be the first step to fixing the admin, I think

comment:1 Changed 8 years ago by Alex

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Changed 8 years ago by Alex

Here is the admin field

comment:2 Changed 8 years ago by brosner

  • Component changed from Admin interface to django.newforms
  • Keywords newforms-admin removed
  • Patch needs improvement set
  • Summary changed from FilePathField still uses Old Forms in newforms-admin to FilePathField needs to be updated to newforms
  • Version changed from newforms-admin to SVN

This is actually a bug in newforms and not just newforms-admin. newforms-admin is effected because it uses newforms in the admin.

Changed 8 years ago by Alex

Both diffs in one!

Changed 8 years ago by Alex

Putting the max_length back into kwargs

comment:3 Changed 8 years ago by SmileyChris

  • Needs documentation set
  • Needs tests set
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Changed 8 years ago by Alex

Adds docs, fixes a few small things

comment:4 Changed 8 years ago by Alex

  • Needs documentation unset

Changed 8 years ago by Alex

comment:5 Changed 8 years ago by Alex

  • Needs tests unset

There are now tests.

Changed 8 years ago by Alex

Fixes a stupid typo from the previous version

Changed 8 years ago by Alex

Fixed the tests

Changed 8 years ago by Alex

Refixed the tests, and made the patch more PEP8(thanks brosner)

Changed 8 years ago by Alex

Added 2 more test cases

Changed 8 years ago by Alex

Fixed a bug introduced last patch

comment:6 Changed 7 years ago by brosner

  • Triage Stage changed from Accepted to Ready for checkin

comment:7 Changed 7 years ago by jacob

  • Owner changed from nobody to jacob

comment:8 Changed 7 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [7323]) Fixed #5894: added FilePathField to newforms. Thanks, Alex Gaynor.

Note: See TracTickets for help on using tickets.
Back to Top