Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#5890 closed (fixed)

Fancy quotes in sitemaps sample code

Reported by: scompt@… Owned by: nobody
Component: Documentation Version: master
Severity: Keywords: quotes
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The bit of code on http://www.djangoproject.com/documentation/sitemaps/ under the Initialization header that shows you how to add sitemaps to your urls.py file uses fancy quotes. This means when you copy the line to a text editor, it won't execute properly.

Here's the current line:

(r’^sitemap.xml$’, ‘django.contrib.sitemaps.views.sitemap’, {‘sitemaps’: sitemaps})

And here's the same with non-fancy quotes:

(r'^sitemap.xml$', 'django.contrib.sitemaps.views.sitemap', {'sitemaps': sitemaps})

Attachments (1)

5890.diff (395 bytes) - added by arien <regexbot@…> 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by arien <regexbot@…>

comment:1 Changed 8 years ago by arien <regexbot@…>

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

Patch to add the missing colon at the end of the preceding paragraph.

comment:2 Changed 8 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [6667]) Fixed #5890 -- Fixed a ReST markup error. Thanks, arien.

comment:3 Changed 8 years ago by mtredinnick

(In [6724]) Fixed #5890 -- fixed the far edge-case of allowing constant strings inside
template template markers: we now treat embedded, escaped double quotes
consistently with constant string arguments to filters. Patch from Dmitri
Fedortchenko.

comment:4 Changed 8 years ago by mtredinnick

Err.. ignore last commit message. Dyslexia on my part.

Note: See TracTickets for help on using tickets.
Back to Top