Opened 9 years ago

Closed 9 years ago

#5887 closed (fixed)

consolidate common code in SafeMIMEText and SafeMIMEMultipart

Reported by: Carl Karsten <carl@…> Owned by: nobody
Component: Core (Mail) Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Browsing the source, noticed the same code in 2 places. moved it into def forbid_multi_line_headers(name, val):

Did not include setitem call - would have been messy, and removed any chance of that function being useful for anything else.

Attachments (1)

mail.diff (1.9 KB) - added by Carl Karsten <carl@…> 9 years ago.
svn diff django/core/mail.py

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by Carl Karsten <carl@…>

Attachment: mail.diff added

svn diff django/core/mail.py

comment:1 Changed 9 years ago by Simon G <dev@…>

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Summary: cosolidate common code in SafeMIMEText and SafeMIMEMultipartconsolidate common code in SafeMIMEText and SafeMIMEMultipart
Triage Stage: UnreviewedReady for checkin

comment:2 Changed 9 years ago by Adrian Holovaty

Resolution: fixed
Status: newclosed

(In [6987]) Fixed #5887 -- Consolidated some duplicate code in SafeMIMEText and SafeMIMEMultipart. Thanks, Carl Karsten

Note: See TracTickets for help on using tickets.
Back to Top