Opened 7 years ago

Closed 7 years ago

#5853 closed (fixed)

javascript_catalog i18n view requires english .mo file

Reported by: miracle2k Owned by: nobody
Component: Internationalization Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Django's javascript_catalog view requires a djangojs catalog for the default language "en" for each application installed. This is inconsistent with the requirements for other i18n functionality, and also seems unnecessary, as it basically equates to "don't do any translation".

The attached patch will still attempt to load an english djangojs.mo file, but moves an if that fails.

Attachments (1)

views.i18n_no_en_required.diff (772 bytes) - added by miracle2k 7 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by miracle2k

comment:1 Changed 7 years ago by Simon G <dev@…>

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 7 years ago by mtredinnick

In future, please create patches from the root of the Django source tree. It makes it much easier to review and apply them (there are three files called i18n.py in the source tree, for example). In this case, I know which file you are patching, so it's okay, so this is just for next time.

comment:3 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [6739]) Fixed #5853 -- Added handling for a missing 'en' PO file in translation support
(this file being missing is essentially harmless). Thanks, miracle2k.

Note: See TracTickets for help on using tickets.
Back to Top