#5801 closed (fixed)
GET parameters are ignored in redirect when user requests URL with GET parameters which needs login
Reported by: | Owned by: | erny | |
---|---|---|---|
Component: | Contrib apps | Version: | 1.0-alpha |
Severity: | Keywords: | autentication login redirect staff_member_required | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
How to reproduce the error:
- as anonymous user, request a page with GET parameters that needs login, e.g. <site>/admin/?test=1
- login page is displayed
- provide valid credentials and confirm
- now you are logged in, but redirected to the URL without GET parameters
Attachments (3)
Change History (12)
by , 17 years ago
Attachment: | decorators.py.patch added |
---|
comment:1 by , 17 years ago
Owner: | changed from | to
---|
comment:2 by , 17 years ago
Status: | new → assigned |
---|
by , 17 years ago
Attachment: | decorators.py.diff added |
---|
File converted to patch rules in contrib page (.diff and relative to django root)
comment:3 by , 17 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:4 by , 16 years ago
On further investigation thanks to Russell Mailing list discussion I started writing tests to get the patch through triage.
I noticed that the behaviour was not the same between the decorator and going to admin direct - something totally missed in the original patch.
New patch incoming with tests :D
comment:6 by , 16 years ago
Julien - yes didn't see that ticket - yes is nearly a duplicate issue except the new patch handles all admin views not just the custom staff_member_required decorated views.
comment:7 by , 16 years ago
milestone: | → 1.0 beta |
---|---|
Version: | SVN → 1.0-alpha |
comment:8 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Patch for contrib/admin/views/decorators.py to treat GET parameters in login-redirect cycle for pages which need login.