Opened 12 years ago

Closed 12 years ago

#5794 closed (fixed)

[patch] newforms DateTimeInput breaks form_for_model rendering

Reported by: MikeH <mike@…> Owned by: nobody
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Malcolm Tredinnick)

Using revision 6593, I have the following problem when rendering forms for models that have DateTimeFields

mikeh@tk421:~/tthome$ ./ shell
Python 2.5.1 (r251:54863, Oct  5 2007, 13:36:32)
[GCC 4.1.3 20070929 (prerelease) (Ubuntu 4.1.2-16ubuntu2)] on linux2
Type "help", "copyright", "credits" or "license" for more information.

from import Event

import django.newforms as forms

f = forms.form_for_model(Event)

form = f()

print form

Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/usr/lib/python2.5/site-packages/django/utils/", line 13, in __str__
    return self.__unicode__().encode('utf-8')
  File "/usr/lib/python2.5/site-packages/django/newforms/", line 80, in __unicode__
    return self.as_table()
  File "/usr/lib/python2.5/site-packages/django/newforms/", line 159, in as_table
    return self._html_output(u'<tr><th>%(label)s</th><td>%(errors)s%(field)s%(help_text)s</td></tr>', u'<tr><td colspan="2">%s</td></tr>', '</td></tr>', u'<br />%s', False)
  File "/usr/lib/python2.5/site-packages/django/newforms/", line 144, in _html_output
    output.append(normal_row % {'errors': force_unicode(bf_errors), 'label': force_unicode(label), 'field': unicode(bf), 'help_text': help_text})
  File "/usr/lib/python2.5/site-packages/django/newforms/", line 251, in __unicode__
    return self.as_widget()
  File "/usr/lib/python2.5/site-packages/django/newforms/", line 279, in as_widget
    return widget.render(self.html_name, data, attrs=attrs)
  File "/usr/lib/python2.5/site-packages/django/newforms/", line 165, in render
    value.strftime(self.format), attrs)
AttributeError: 'NoneType' object has no attribute 'strftime'

The attached patch fixes this behavior, but it might not be the best solution...

Attachments (2)

widgetpatch.diff (585 bytes) - added by MikeH <mike@…> 12 years ago.
Detects for None when rendering (1.2 KB) - added by anonymous 10 years ago.

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by MikeH <mike@…>

Attachment: widgetpatch.diff added

Detects for None when rendering

comment:1 Changed 12 years ago by Malcolm Tredinnick

Description: modified (diff)
Triage Stage: UnreviewedAccepted

Wow. I'm an idiot. Not sure how I missed testing that case. Sorry about that.

Your patch looks like the right idea.

comment:2 Changed 12 years ago by Malcolm Tredinnick

Resolution: fixed
Status: newclosed

(In [6594]) Fixed #5794 -- Be more robust when rendering a DateTimeInput widget. Thanks,

Changed 10 years ago by anonymous

Attachment: added
Note: See TracTickets for help on using tickets.
Back to Top