Opened 7 years ago

Closed 7 years ago

#5794 closed (fixed)

[patch] newforms DateTimeInput breaks form_for_model rendering

Reported by: MikeH <mike@…> Owned by: nobody
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description (last modified by mtredinnick)

Using revision 6593, I have the following problem when rendering forms for models that have DateTimeFields

mikeh@tk421:~/tthome$ ./manage.py shell
Python 2.5.1 (r251:54863, Oct  5 2007, 13:36:32)
[GCC 4.1.3 20070929 (prerelease) (Ubuntu 4.1.2-16ubuntu2)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
(InteractiveConsole)

from tthome.events.models import Event

import django.newforms as forms

f = forms.form_for_model(Event)

form = f()

print form

Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/usr/lib/python2.5/site-packages/django/utils/encoding.py", line 13, in __str__
    return self.__unicode__().encode('utf-8')
  File "/usr/lib/python2.5/site-packages/django/newforms/forms.py", line 80, in __unicode__
    return self.as_table()
  File "/usr/lib/python2.5/site-packages/django/newforms/forms.py", line 159, in as_table
    return self._html_output(u'<tr><th>%(label)s</th><td>%(errors)s%(field)s%(help_text)s</td></tr>', u'<tr><td colspan="2">%s</td></tr>', '</td></tr>', u'<br />%s', False)
  File "/usr/lib/python2.5/site-packages/django/newforms/forms.py", line 144, in _html_output
    output.append(normal_row % {'errors': force_unicode(bf_errors), 'label': force_unicode(label), 'field': unicode(bf), 'help_text': help_text})
  File "/usr/lib/python2.5/site-packages/django/newforms/forms.py", line 251, in __unicode__
    return self.as_widget()
  File "/usr/lib/python2.5/site-packages/django/newforms/forms.py", line 279, in as_widget
    return widget.render(self.html_name, data, attrs=attrs)
  File "/usr/lib/python2.5/site-packages/django/newforms/widgets.py", line 165, in render
    value.strftime(self.format), attrs)
AttributeError: 'NoneType' object has no attribute 'strftime'

The attached patch fixes this behavior, but it might not be the best solution...

Attachments (2)

widgetpatch.diff (585 bytes) - added by MikeH <mike@…> 7 years ago.
Detects for None when rendering
views.py (1.2 KB) - added by anonymous 5 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by MikeH <mike@…>

Detects for None when rendering

comment:1 Changed 7 years ago by mtredinnick

  • Description modified (diff)
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Wow. I'm an idiot. Not sure how I missed testing that case. Sorry about that.

Your patch looks like the right idea.

comment:2 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [6594]) Fixed #5794 -- Be more robust when rendering a DateTimeInput widget. Thanks,
MikeH.

Changed 5 years ago by anonymous

Note: See TracTickets for help on using tickets.
Back to Top