Code

Opened 7 years ago

Closed 7 years ago

#5790 closed (wontfix)

Add support for Cc: in django/core/mail.py

Reported by: tpetazzoni Owned by: nobody
Component: Core (Other) Version: master
Severity: Keywords:
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The attached patch adds support for Cc: in django/core/mail.py. Using the already existing 'headers' argument of the EmailMessage constructor is not enough, because just like Bcc addresses, Cc addresses must be passed to the RCPT TO command, so they must be present in the list returned by the recipients() method.

Attachments (1)

django-core-mail-add-cc-support (1.5 KB) - added by tpetazzoni 7 years ago.
Patch that adds support for Cc

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by tpetazzoni

Patch that adds support for Cc

comment:1 Changed 7 years ago by mtredinnick

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

I've generally been -1 on this in the past. We're not aiming to implement all-singing, all-dancing email functionality here, since that already exists in the Python library.

You can send to anybody you like using the "to" line, or you can subclass EmailMessage to add CC functionality if you really want it (c.f. we needed to add Bcc because you can't use "to" for that). So this patch adds no functionality that isn't already possible, but adds more complexity to the code and the API.

Leaving open for a little while in case another core dev has a differing opinion.

comment:2 Changed 7 years ago by jacob

  • Resolution set to wontfix
  • Status changed from new to closed

No, I completely agree with Malcolm.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.