Mixed up docs in django/contrib/comments/feeds.py

[Ludvig Ericson <ludvig.ericson@…>]

django/contrib/comments/feeds.py has a hard-wired limit, and the comments are mixed up, and in different styles.

Patch lets one do:

class MyCommentsFeed(LatestFreeCommentsFeed):
    comment_count_limit = 10

[Gary Wilson]

Well, you could just use the queryset directly instead of the items() convenience method:

myfeed = LatestFreeCommentsFeed(...)
myfeed.get_query_set()[:10]

As far as the patch goes, I'm not sure if this should be a class attribute. Maybe just a parameter to items:

    def items(self, limit=40):
        if limit:
            return self.get_query_set()[:limit]
        else:
            return self.get_query_set()

But seeing how any of this would just be another way to do something that's already possible, I'm going to close this as a wontfix.

[Ludvig Ericson <ludvig.ericson@…>]

Yeah, but the feeds framework calls those automatically, I don't - but fine, there's no point in arguing about that, just that my way is the easier fix for a larger problem.

Notice how there's still a bug, with the comments of both classes. They're plain wrong.

[Ludvig Ericson <ludvig.ericson@…>]

Maybe docs is a better word.

[Malcolm Tredinnick]

I agree with Gary -- no need to change the functionality here. The comments aren't wrong either: a docstring can be any string and there are strings like this as docstrings throughout Django.

[Ludvig Ericson <ludvig.ericson@…>]

I don't care what string notation you use, not the least bit.

Read the contents, they're plain wrong.

[Ludvig Ericson <ludvig.ericson@…>]

It has been changed.