Opened 8 years ago

Closed 7 years ago

#5733 closed (fixed)

[newforms-admin] - add formset_for_queryset

Reported by: brosner Owned by: jkocherhans
Component: contrib.admin Version: newforms-admin
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In a discussion with Joseph, we both came to the conclusion that a helper method for multiple instances is tough. http://groups.google.com/group/django-developers/browse_frm/thread/b2a177e123e14947. I have actually devised a patch to allow for this. This patch is *not* complete. It is more or less a proof of concept along with some tests to boot. Joseph would you mind taking a quick peak?

Attachments (3)

5733_formset_for_queryset.diff (8.5 KB) - added by brosner 8 years ago.
incomplete, but proof of concept with tests
form_for_queryset.diff (17.2 KB) - added by jkocherhans 7 years ago.
This may not apply cleanly anymore, but you get the idea, hopefully.
r6614_formset_for_queryset.diff (14.1 KB) - added by brosner 7 years ago.
updated patch to match r6614. also includes a missing file and passes all tests.

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by brosner

incomplete, but proof of concept with tests

comment:1 Changed 8 years ago by jkocherhans

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to jkocherhans
  • Patch needs improvement unset
  • Status changed from new to assigned

Just FYI this gave me a lot of new ideas and I'm refactoring some of the model-formset integration stuff as a result. Not sure when I'll have any results, but it's in progress.

Changed 7 years ago by jkocherhans

This may not apply cleanly anymore, but you get the idea, hopefully.

Changed 7 years ago by brosner

updated patch to match r6614. also includes a missing file and passes all tests.

comment:2 Changed 7 years ago by brosner

I have attached an updated version of the patch to work against r6614 in newforms-admin (most current at this time). It also includes an __init__.py missing from Joseph's patch and it passes all tests. I haven't been able to apply this to my working copy of newforms-admin for the site I am building with it, but will be able to do so soon. It will get some good exposure to lots of data and see how it handles and works overall.

comment:3 Changed 7 years ago by jkocherhans

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [6655]) newforms-admin: Fixed #5733. Added formset_for_queryset. This is backwards incompatble for anyone using formset_for_model or BaseModelFormSet.

Note: See TracTickets for help on using tickets.
Back to Top