Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#5695 closed (fixed)

[newform-admin] - i18n and xhtml problem in AdminFileWidget

Reported by: Petr Marhoun <petr.marhoun@…> Owned by: nobody
Component: contrib.admin Version: newforms-admin
Severity: Keywords: nfa-blocker AdminFileWidget i18n invalid html
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Improvements introduced in [6457] are not internationalized and are not xhtml compatible.

Attachments (2)

admin-file-widget.diff (689 bytes) - added by Petr Marhoun <petr.marhoun@…> 8 years ago.
5695.diff (1.4 KB) - added by garcia_marc 7 years ago.
Improved patch

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by Petr Marhoun <petr.marhoun@…>

comment:1 Changed 8 years ago by brosner

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

Looks good to me. Marking as Ready for checkin.

comment:2 Changed 7 years ago by garcia_marc

  • Cc marc.garcia@… added
  • Component changed from Internationalization to Admin interface
  • Keywords AdminFileWidget i18n invalid html added

Previous patch improved:

  • target="_blank" isn't valid in xhtml strict, changed to javascript
  • Translatable labels not including colon
  • Tests added

Changed 7 years ago by garcia_marc

Improved patch

comment:3 Changed 7 years ago by brosner

  • Keywords nfa-blocker added

This is pretty trivial and does need to be fixed before a merge to trunk. Tagging nfa-blocker.

comment:4 Changed 7 years ago by brosner

I am going to fix this, but can the target="_blank" stuff be opened in a new ticket. I would rather deal with that separately.

comment:5 Changed 7 years ago by brosner

  • Resolution set to fixed
  • Status changed from new to closed

(In [7212]) newforms-admin: Fixed #5695. AdminFileWidget now properly marks strings for translation and a minor XHTML fix.

comment:6 Changed 7 years ago by garcia_marc

  • Cc marc.garcia@… removed

Thanks for commiting.

Your ticket for target="_blank" is #6750

Note: See TracTickets for help on using tickets.
Back to Top