#5655 closed (fixed)
FileField's _save_FIELD_file method evaluates the directory once for creating the directory, then again for creating the file
| Reported by: | Chris Beaven | Owned by: | Marty Alchin |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | dev |
| Severity: | Keywords: | fs-rf-fixed | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
I'm sure there's a more succinct way to say that...
Anyway, the directory should only be calculated once, to avoid potentially creating one time-based upload directory the then attempting to upload to a different directory.
Attachments (1)
Change History (8)
by , 17 years ago
| Attachment: | 5655.patch added |
|---|
comment:1 by , 16 years ago
| Keywords: | fs-rf added |
|---|
comment:2 by , 16 years ago
| Keywords: | fs-rf-fixed added; fs-rf removed |
|---|
comment:3 by , 16 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:4 by , 16 years ago
| milestone: | → 1.0 beta |
|---|
comment:5 by , 16 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:6 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
(In [8244]) File storage refactoring, adding far more flexibility to Django's file handling. The new files.txt document has details of the new features.
This is a backwards-incompatible change; consult BackwardsIncompatibleChanges for details.
Fixes #3567, #3621, #4345, #5361, #5655, #7415.
Many thanks to Marty Alchin who did the vast majority of this work.