Opened 8 years ago

Closed 7 years ago

Last modified 4 years ago

#5655 closed (fixed)

FileField's _save_FIELD_file method evaluates the directory once for creating the directory, then again for creating the file

Reported by: SmileyChris Owned by: Gulopine
Component: Database layer (models, ORM) Version: master
Severity: Keywords: fs-rf-fixed
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


I'm sure there's a more succinct way to say that...

Anyway, the directory should only be calculated once, to avoid potentially creating one time-based upload directory the then attempting to upload to a different directory.

Attachments (1)

5655.patch (1.6 KB) - added by SmileyChris 8 years ago.

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by SmileyChris

comment:1 Changed 8 years ago by Gulopine

  • Keywords fs-rf added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 8 years ago by Gulopine

  • Keywords fs-rf-fixed added; fs-rf removed

comment:3 Changed 8 years ago by jacob

  • Triage Stage changed from Unreviewed to Accepted

comment:4 Changed 7 years ago by Gulopine

  • milestone set to 1.0 beta

comment:5 Changed 7 years ago by Gulopine

  • Owner changed from nobody to Gulopine
  • Status changed from new to assigned

comment:6 Changed 7 years ago by jacob

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [8244]) File storage refactoring, adding far more flexibility to Django's file handling. The new files.txt document has details of the new features.

This is a backwards-incompatible change; consult BackwardsIncompatibleChanges for details.

Fixes #3567, #3621, #4345, #5361, #5655, #7415.

Many thanks to Marty Alchin who did the vast majority of this work.

comment:11 Changed 4 years ago by jacob

  • milestone 1.0 beta deleted

Milestone 1.0 beta deleted

Note: See TracTickets for help on using tickets.
Back to Top