Opened 9 years ago

Closed 9 years ago

#5644 closed (fixed)

Fix invalid html on the Django Project site

Reported by: Marc Garcia Owned by: nobody
Component: *.djangoproject.com Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Recently added mt image at footer of django web page, has added without closing tag slash. This made html code not valid according to standards.

Necessary change:
from: <img style="vertical-align: middle; position: relative; top: -1px;" src="http://media.djangoproject.com/img/site/mt.png" alt="media temple">
to: <img style="vertical-align: middle; position: relative; top: -1px;" src="http://media.djangoproject.com/img/site/mt.png" alt="media temple"/>

Attachments (2)

5644.diff (1005 bytes) - added by Marc Garcia 9 years ago.
base.html changed to follow standards
5644.2.diff (1.0 KB) - added by Gary Wilson 9 years ago.
Converted a few spaces to tabs to match rest of file. Added a missing closing div tag. Added a missing closing slash to img tag.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 9 years ago by anonymous

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Summary: mt image makes html code invalidUnclosed image tag makes the Django site's html code invalid
Triage Stage: UnreviewedReady for checkin

comment:2 Changed 9 years ago by Chris Beaven

(me promoting) damn you, basic http auth!

Changed 9 years ago by Marc Garcia

Attachment: 5644.diff added

base.html changed to follow standards

comment:3 Changed 9 years ago by Marc Garcia

Has patch: set
Version: SVN

Attached patch that fixes problem. Ready for check in. :)

Changed 9 years ago by Gary Wilson

Attachment: 5644.2.diff added

Converted a few spaces to tabs to match rest of file.
Added a missing closing div tag.
Added a missing closing slash to img tag.

comment:4 Changed 9 years ago by Chris Beaven

Keywords: mt logo web footer removed
Summary: Unclosed image tag makes the Django site's html code invalidFix invalid html on the Django Project site

comment:5 Changed 9 years ago by Jacob

Resolution: fixed
Status: newclosed

(In [6757]) Fixed #5644: a quick HTML validation fix.

Note: See TracTickets for help on using tickets.
Back to Top