Code

Opened 7 years ago

Closed 6 years ago

#5644 closed (fixed)

Fix invalid html on the Django Project site

Reported by: garcia_marc Owned by: nobody
Component: *.djangoproject.com Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Recently added mt image at footer of django web page, has added without closing tag slash. This made html code not valid according to standards.

Necessary change:
from: <img style="vertical-align: middle; position: relative; top: -1px;" src="http://media.djangoproject.com/img/site/mt.png" alt="media temple">
to: <img style="vertical-align: middle; position: relative; top: -1px;" src="http://media.djangoproject.com/img/site/mt.png" alt="media temple"/>

Attachments (2)

5644.diff (1005 bytes) - added by garcia_marc 6 years ago.
base.html changed to follow standards
5644.2.diff (1.0 KB) - added by gwilson 6 years ago.
Converted a few spaces to tabs to match rest of file. Added a missing closing div tag. Added a missing closing slash to img tag.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by anonymous

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Summary changed from mt image makes html code invalid to Unclosed image tag makes the Django site's html code invalid
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 7 years ago by SmileyChris

(me promoting) damn you, basic http auth!

Changed 6 years ago by garcia_marc

base.html changed to follow standards

comment:3 Changed 6 years ago by garcia_marc

  • Has patch set
  • Version set to SVN

Attached patch that fixes problem. Ready for check in. :)

Changed 6 years ago by gwilson

Converted a few spaces to tabs to match rest of file.
Added a missing closing div tag.
Added a missing closing slash to img tag.

comment:4 Changed 6 years ago by SmileyChris

  • Keywords mt logo web footer removed
  • Summary changed from Unclosed image tag makes the Django site's html code invalid to Fix invalid html on the Django Project site

comment:5 Changed 6 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [6757]) Fixed #5644: a quick HTML validation fix.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.