Opened 8 years ago

Closed 7 years ago

Last modified 4 years ago

#5628 closed (fixed)

[newforms-admin] - when an inline formset has errors, no message is displayed at the top of the form

Reported by: brosner Owned by: jkocherhans
Component: contrib.admin Version: newforms-admin
Severity: Keywords: nfa-blocker
Cc: framos@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

If an inline formset has any validation errors then the error message Please correct the errors below. won't be displayed at the top of the form.

Attachments (3)

5628_formset_errors_fix.diff (3.2 KB) - added by brosner 8 years ago.
00-admin-errors (2.2 KB) - added by Petr Marhoun <petr.marhoun@…> 8 years ago.
00-admin-errors.diff (2.2 KB) - added by Petr Marhoun <petr.marhoun@…> 8 years ago.
version with correct suffix

Download all attachments as: .zip

Change History (12)

comment:1 Changed 8 years ago by jkocherhans

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to jkocherhans
  • Patch needs improvement unset
  • Status changed from new to assigned
  • Triage Stage changed from Unreviewed to Accepted

Changed 8 years ago by brosner

comment:2 Changed 8 years ago by brosner

I have attached a patch that I am using to solve this problem. Not the best patch, some cleanup work is needed, but nonetheless it works. My apolozigies if anything is wrong with the patch since I am still trying to improve my life with SVK slowly, but surely ;)

Changed 8 years ago by Petr Marhoun <petr.marhoun@…>

Changed 8 years ago by Petr Marhoun <petr.marhoun@…>

version with correct suffix

comment:3 Changed 8 years ago by Petr Marhoun <petr.marhoun@…>

Another version of patch - I think it is necessary to count all errors. So it can be chosen if "Please correct the error below." or "Please correct the errors below." should be used.

comment:4 Changed 8 years ago by brosner

  • Keywords nfa-blocker added

Ah, much better patch than mine with the hacked up code ;) Marking as nfa-blocker.

comment:5 Changed 8 years ago by Alex

  • Has patch set

comment:6 Changed 7 years ago by framos

  • Cc framos@… added

comment:7 Changed 7 years ago by garcia_marc

  • milestone set to 1.0 alpha

comment:8 Changed 7 years ago by Alex

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in r7878

comment:9 Changed 4 years ago by jacob

  • milestone 1.0 alpha deleted

Milestone 1.0 alpha deleted

Note: See TracTickets for help on using tickets.
Back to Top