Opened 16 years ago

Closed 16 years ago

Last modified 12 years ago

#5628 closed (fixed)

[newforms-admin] - when an inline formset has errors, no message is displayed at the top of the form

Reported by: Brian Rosner Owned by: jkocherhans
Component: contrib.admin Version: newforms-admin
Severity: Keywords: nfa-blocker
Cc: framos@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

If an inline formset has any validation errors then the error message Please correct the errors below. won't be displayed at the top of the form.

Attachments (3)

5628_formset_errors_fix.diff (3.2 KB ) - added by Brian Rosner 16 years ago.
00-admin-errors (2.2 KB ) - added by Petr Marhoun <petr.marhoun@…> 16 years ago.
00-admin-errors.diff (2.2 KB ) - added by Petr Marhoun <petr.marhoun@…> 16 years ago.
version with correct suffix

Download all attachments as: .zip

Change History (12)

comment:1 by jkocherhans, 16 years ago

Owner: changed from nobody to jkocherhans
Status: newassigned
Triage Stage: UnreviewedAccepted

by Brian Rosner, 16 years ago

comment:2 by Brian Rosner, 16 years ago

I have attached a patch that I am using to solve this problem. Not the best patch, some cleanup work is needed, but nonetheless it works. My apolozigies if anything is wrong with the patch since I am still trying to improve my life with SVK slowly, but surely ;)

by Petr Marhoun <petr.marhoun@…>, 16 years ago

Attachment: 00-admin-errors added

by Petr Marhoun <petr.marhoun@…>, 16 years ago

Attachment: 00-admin-errors.diff added

version with correct suffix

comment:3 by Petr Marhoun <petr.marhoun@…>, 16 years ago

Another version of patch - I think it is necessary to count all errors. So it can be chosen if "Please correct the error below." or "Please correct the errors below." should be used.

comment:4 by Brian Rosner, 16 years ago

Keywords: nfa-blocker added

Ah, much better patch than mine with the hacked up code ;) Marking as nfa-blocker.

comment:5 by Alex Gaynor, 16 years ago

Has patch: set

comment:6 by Fidel Ramos, 16 years ago

Cc: framos@… added

comment:7 by Marc Garcia, 16 years ago

milestone: 1.0 alpha

comment:8 by Alex Gaynor, 16 years ago

Resolution: fixed
Status: assignedclosed

Fixed in r7878

comment:9 by Jacob, 12 years ago

milestone: 1.0 alpha

Milestone 1.0 alpha deleted

Note: See TracTickets for help on using tickets.
Back to Top