Opened 8 years ago

Closed 8 years ago

#5604 closed (fixed)

Access over HTTPS broken when using WSGI

Reported by: ramiro Owned by: nobody
Component: HTTP handling Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


The WSGI handler relies on the presence of the 'HTTPS' environment var to detect the use of HTTPS.

WSGI spec dictates a server-side implementation MUST export a 'wsgi.url_scheme' var and SHOULD
export a 'HTTPS' var.

Fix is a one-line patch.

discussed on:

Attachments (1)

wsgi_https.diff (655 bytes) - added by ramiro 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by ramiro

comment:1 Changed 8 years ago by ramiro

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 8 years ago by SmileyChris

  • Triage Stage changed from Unreviewed to Ready for checkin

Yep, it's good.

comment:3 Changed 8 years ago by gwilson

  • Resolution set to fixed
  • Status changed from new to closed

(In [6428]) Fixed #5604 -- Check for use of HTTPS by looking at the wsgi.url_scheme environment variable instead of the HTTPS environment variable since wsgi.url_scheme is required by the WSGI spec, while HTTPS is not. Thanks, ramiro.

Note: See TracTickets for help on using tickets.
Back to Top