Opened 9 years ago

Closed 9 years ago

#5585 closed (duplicate)

Default manager methods should allow _id style arguments for foreign keys

Reported by: Simon Litchfield <simon@…> Owned by: nobody
Component: Database layer (models, ORM) Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


Instead of being required to do this --

current_user = User.objects.get(id=47)
profile = Profile.objects.get(name='Example', user=current_user)

Since I can use profile.user_id, I would expect to be able to do this --

profile = Profile.objects.get(name='Example', user_id=47)

Both in terms of consistency *and* performance.

Another example gotcha, which obviously makes sense once you know it but needn't be the case if filters etc supported _id style arguments --

pa, created = ProfileAttrib.objects.get_or_create(profile=self.profile,

Why not, just --

pa, created = ProfileAttrib.objects.get_or_create(profile=self.profile,

Change History (1)

comment:1 Changed 9 years ago by James Bennett

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Resolution: duplicate
Status: newclosed

Duplicate of #5535.

Note: See TracTickets for help on using tickets.
Back to Top