Opened 6 years ago
Closed 6 years ago
#5504 closed (fixed)
Backwards-incompatible change introduced by [6289]
| Reported by: | jshaffer | Owned by: | mtredinnick |
|---|---|---|---|
| Component: | Template system | Version: | master |
| Severity: | Keywords: | sprintsept14 | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | UI/UX: |
Description
Before [6289], {% load satchmo.google %} was identical to {% load google %} (because everything before the last segment was ignored). With [6289] or later, {% load satchmo.google %} raises a TemplateSyntaxError.
The change in behavior should be reverted or documented. I personally prefer the new behavior (although the old was nice to give an indication of where the tags really came from, this change is overall for the better).
References Satchmo #155.
Attachments (0)
Change History (4)
comment:1 Changed 6 years ago by jshaffer
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset
comment:2 Changed 6 years ago by Simon G. <dev@…>
- Triage Stage changed from Unreviewed to Accepted
comment:3 Changed 6 years ago by mtredinnick
- Owner changed from nobody to mtredinnick
comment:4 Changed 6 years ago by mtredinnick
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
Should be documented as backwards-incompatible. I hadn't thought that anybody would be relying on the old behaviour for useful purposes.
I'll fix this on the wiki page.