Removing the automatic colon from newforms' _html_output

[anonymous]

The _html_output() method automatically adds a colon at the end of a field's label if the label name does not end with a punctuation symbol. I move to completely remove this behavior and let the programmer choose if he wants a colon or not by specifying it him/herself in his form definition. Django should not make presentation decisions for the user.

Here is the code in question, it's in django/newforms/forms.py on line 132 in r6345

# Only add a colon if the label does not end in punctuation.
if label[-1] not in ':?.!':
    label += ':'

[Vincent Foley]

I've added a (rather large) patch to fix the issue. The patch remove the three lines previously mentioned from forms.py and the rest of the patch is to fix the large suite of unit tests.

[Vincent Foley]

Dupe. See #4975