Opened 9 years ago

Closed 6 years ago

#5500 closed (wontfix)

Add an adminindex templatetag

Reported by: jkocherhans Owned by: Jannis Leidel
Component: contrib.admin Version: master
Severity: Keywords: sprintdec01 edit inline add
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description (last modified by Jacob)

The adminindex command [removed in r8548 --JKM] can only act on one site. Replacing its functionality with a templatetag, or possibly just an include would be a more robust solution.

Attachments (1)

adminindex.diff (4.7 KB) - added by Jannis Leidel 9 years ago.
Implemented template tag admin_index in django.contrib.admin.templatetags.admin_list which is now also used by django.core.management.commands.adminindex

Download all attachments as: .zip

Change History (16)

comment:1 Changed 9 years ago by jkocherhans

Triage Stage: UnreviewedAccepted

comment:2 Changed 9 years ago by Jannis Leidel

Owner: changed from nobody to Jannis Leidel

Changed 9 years ago by Jannis Leidel

Attachment: adminindex.diff added

Implemented template tag admin_index in django.contrib.admin.templatetags.admin_list which is now also used by django.core.management.commands.adminindex

comment:3 Changed 9 years ago by Jannis Leidel

Has patch: set

comment:4 Changed 9 years ago by Jannis Leidel

Keywords: sprintdec01 added

comment:5 Changed 9 years ago by Brian Rosner

Keywords: nfa-someday edit inline add added

This isn't critical to the merge of newforms-admin. Tagging with nfa-someday. This looks reasonable and should eventually be fixed, but lets not get it in our way of merging newforms-admin.

comment:6 Changed 9 years ago by Jannis Leidel

In other words: it won't be fixed. right?

comment:7 Changed 9 years ago by Brian Rosner

No, this isn't a blocking task that has to be done before merging to trunk with newforms-admin. The ticket has been accepted and I think should get included. If there is time before merging then it should be looked at again.

comment:8 Changed 9 years ago by Jannis Leidel

Ok, this sounds reasonable. Thanks for clarification!

comment:9 Changed 8 years ago by Jannis Leidel

Resolution: fixed
Status: newclosed
Triage Stage: AcceptedFixed on a branch

comment:10 Changed 8 years ago by Michał Sałaban

Resolution: fixed
Status: closedreopened

Has this patch been applied? Searching by the ticket number does not return any changeset and neither trunk nor newforms-admin branch have it.

comment:11 Changed 8 years ago by Jannis Leidel

Keywords: nfa-someday removed
milestone: 1.0
Patch needs improvement: set
Triage Stage: Fixed on a branchAccepted
Version: newforms-adminSVN

No, this patch hasn't been applied and the admin-index command hasn't been updated for newforms-admin. Given django.contrib.admin.site.index() I would also say it should use the functionality there to print those templates.

I talked to jkocherhans and brosner briefly on IRC and they said it should be looked at, hence marking it as 1.0.

comment:12 Changed 8 years ago by Jacob

(In [8548]) Removed outdated "adminindex" command -- the same behavior is now far easier and better done in a template, or perhaps a custom AdminSite.index function. Refs #5500.

comment:13 Changed 8 years ago by Jacob

Description: modified (diff)
milestone: 1.0post-1.0
Summary: Replace the adminindex command with a suitable templatetagAdd an adminindex templatetag
Triage Stage: AcceptedDesign decision needed

I've pushing this back down to DDN for the question of weather a template tag is needed at all; it's post-1.0 either way.

comment:14 Changed 8 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

comment:15 Changed 6 years ago by Malcolm Tredinnick

Resolution: wontfix
Status: reopenedclosed

After discussion with jezdez, we feel there's enough customisation of templates possible, including multi-site template differentiation, that this isn't really needed any longer. Closing for now.

Note: See TracTickets for help on using tickets.
Back to Top