Opened 8 years ago

Closed 5 years ago

#5500 closed (wontfix)

Add an adminindex templatetag

Reported by: jkocherhans Owned by: jezdez
Component: contrib.admin Version: master
Severity: Keywords: sprintdec01 edit inline add
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description (last modified by jacob)

The adminindex command [removed in r8548 --JKM] can only act on one site. Replacing its functionality with a templatetag, or possibly just an include would be a more robust solution.

Attachments (1)

adminindex.diff (4.7 KB) - added by jezdez 8 years ago.
Implemented template tag admin_index in django.contrib.admin.templatetags.admin_list which is now also used by django.core.management.commands.adminindex

Download all attachments as: .zip

Change History (16)

comment:1 Changed 8 years ago by jkocherhans

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 8 years ago by jezdez

  • Owner changed from nobody to jezdez

Changed 8 years ago by jezdez

Implemented template tag admin_index in django.contrib.admin.templatetags.admin_list which is now also used by django.core.management.commands.adminindex

comment:3 Changed 8 years ago by jezdez

  • Has patch set

comment:4 Changed 8 years ago by jezdez

  • Keywords sprintdec01 added

comment:5 Changed 7 years ago by brosner

  • Keywords nfa-someday edit inline add added

This isn't critical to the merge of newforms-admin. Tagging with nfa-someday. This looks reasonable and should eventually be fixed, but lets not get it in our way of merging newforms-admin.

comment:6 Changed 7 years ago by jezdez

In other words: it won't be fixed. right?

comment:7 Changed 7 years ago by brosner

No, this isn't a blocking task that has to be done before merging to trunk with newforms-admin. The ticket has been accepted and I think should get included. If there is time before merging then it should be looked at again.

comment:8 Changed 7 years ago by jezdez

Ok, this sounds reasonable. Thanks for clarification!

comment:9 Changed 7 years ago by jezdez

  • Resolution set to fixed
  • Status changed from new to closed
  • Triage Stage changed from Accepted to Fixed on a branch

comment:10 Changed 7 years ago by emes

  • Resolution fixed deleted
  • Status changed from closed to reopened

Has this patch been applied? Searching by the ticket number does not return any changeset and neither trunk nor newforms-admin branch have it.

comment:11 Changed 7 years ago by jezdez

  • Keywords nfa-someday removed
  • milestone set to 1.0
  • Patch needs improvement set
  • Triage Stage changed from Fixed on a branch to Accepted
  • Version changed from newforms-admin to SVN

No, this patch hasn't been applied and the admin-index command hasn't been updated for newforms-admin. Given django.contrib.admin.site.index() I would also say it should use the functionality there to print those templates.

I talked to jkocherhans and brosner briefly on IRC and they said it should be looked at, hence marking it as 1.0.

comment:12 Changed 7 years ago by jacob

(In [8548]) Removed outdated "adminindex" command -- the same behavior is now far easier and better done in a template, or perhaps a custom AdminSite.index function. Refs #5500.

comment:13 Changed 7 years ago by jacob

  • Description modified (diff)
  • milestone changed from 1.0 to post-1.0
  • Summary changed from Replace the adminindex command with a suitable templatetag to Add an adminindex templatetag
  • Triage Stage changed from Accepted to Design decision needed

I've pushing this back down to DDN for the question of weather a template tag is needed at all; it's post-1.0 either way.

comment:14 Changed 6 years ago by anonymous

  • milestone post-1.0 deleted

Milestone post-1.0 deleted

comment:15 Changed 5 years ago by mtredinnick

  • Resolution set to wontfix
  • Status changed from reopened to closed

After discussion with jezdez, we feel there's enough customisation of templates possible, including multi-site template differentiation, that this isn't really needed any longer. Closing for now.

Note: See TracTickets for help on using tickets.
Back to Top