Opened 8 years ago

Closed 8 years ago

#5468 closed (fixed)

[patch] direct_to_template uses literal dict in keyword arg

Reported by: durdinator Owned by: nobody
Component: Template system Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

This is not a real problem, just bad practice, with a trivial fix.

def direct_to_template(request, template, extra_context={}, mimetype=None, **kwargs)

Attachments (1)

patch_5468.diff (861 bytes) - added by durdinator 8 years ago.
Fix

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by durdinator

Fix

comment:1 Changed 8 years ago by durdinator

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 8 years ago by flother

  • Summary changed from direct_to_template uses literal dict in keyword arg to [patch] direct_to_template uses literal dict in keyword arg
  • Triage Stage changed from Unreviewed to Ready for checkin

All the other views in the django.views.generic package do this, so it seems fair to accept this patch.

comment:3 Changed 8 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [6278]) Fixed #5468 -- Fixed the handling of the context argument in direct_to_template generic views. Thanks, durdinator.

Note: See TracTickets for help on using tickets.
Back to Top