Code

Opened 7 years ago

Closed 7 years ago

#5457 closed (fixed)

Move permissions checking to auth backend

Reported by: Florian Apolloner Owned by: jacob
Component: Contrib apps Version: newforms-admin
Severity: Keywords: backend permissions sprintsept14
Cc: django@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The included patch moves permission checking to the auth_backends as I am using an ldap server to auth against this would become handy.

The patch is against newforms-admin, but should work in trunk too...

Attachments (6)

backend_user_permissions.diff (144 bytes) - added by Florian Apolloner 7 years ago.
backend_user_permissions.2.diff (7.5 KB) - added by Florian Apolloner 7 years ago.
Upps, old one was empty…
doc.diff (1.5 KB) - added by Florian Apolloner 7 years ago.
I added some docs. Please apologize my bad English.
full_diff (9.0 KB) - added by Florian Apolloner 7 years ago.
full diff including docs and tests (I hope everything works, as I am really tired now XD)
full_diff.diff (9.0 KB) - added by Florian Apolloner 7 years ago.
full diff including docs and tests (I hope everything works, as I am really tired now XD)
full_diff.2.diff (11.8 KB) - added by Florian Apolloner 7 years ago.
full diff including docs and tests (I hope everything works, as I am really tired now XD) [last one missed the tests...]

Download all attachments as: .zip

Change History (12)

Changed 7 years ago by Florian Apolloner

Changed 7 years ago by Florian Apolloner

Upps, old one was empty...

comment:1 Changed 7 years ago by apollo13

  • Needs documentation set
  • Needs tests unset
  • Owner changed from nobody to apollo13
  • Patch needs improvement unset
  • Status changed from new to assigned
  • Triage Stage changed from Unreviewed to Design decision needed

I'll start writing the docu, and set this to "design decision needed" for now...

comment:2 Changed 7 years ago by anonymous

  • Keywords sprintsept14 added

Changed 7 years ago by Florian Apolloner

I added some docs. Please apologize my bad English.

comment:3 Changed 7 years ago by Florian Apolloner

  • Needs documentation unset

Changed 7 years ago by Florian Apolloner

full diff including docs and tests (I hope everything works, as I am really tired now XD)

Changed 7 years ago by Florian Apolloner

full diff including docs and tests (I hope everything works, as I am really tired now XD)

Changed 7 years ago by Florian Apolloner

full diff including docs and tests (I hope everything works, as I am really tired now XD) [last one missed the tests...]

comment:4 Changed 7 years ago by apollo13

  • Owner changed from apollo13 to jacob
  • Status changed from assigned to new
  • Triage Stage changed from Design decision needed to Ready for checkin

Assigning to jacob and switching to ready for checkin, he is going to review it this weekend :)

-- Florian Apolloner <florian at apolloner.eu>

comment:5 Changed 7 years ago by apollo13

The diff file includes the empty init.py but it is not getting applied during patching (and I really don't know why), sry jacob

comment:6 Changed 7 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [6375].

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.